mirror of
https://github.com/torvalds/linux.git
synced 2026-05-29 17:43:52 +02:00
23c39cb598
clang-22 warns about csiphy_match_clock_name() taking a variable format
string that is not checked against the 'int index' argument:
drivers/media/platform/qcom/camss/camss-csiphy.c:566:44: error: diagnostic behavior may be improved by
adding the 'format(printf, 2, 3)' attribute to the declaration of 'csiphy_match_clock_name'
[-Werror,-Wmissing-format-attribute]
561 | static bool csiphy_match_clock_name(const char *clock_name, const char *format,
| __attribute__((format(printf, 2, 3)))
562 | int index)
563 | {
564 | char name[16]; /* csiphyXXX_timer\0 */
565 |
566 | snprintf(name, sizeof(name), format, index);
| ^
drivers/media/platform/qcom/camss/camss-csiphy.c:561:13: note: 'csiphy_match_clock_name' declared here
561 | static bool csiphy_match_clock_name(const char *clock_name, const char *format,
| ^
Change the function to use a snprintf() style format string that allows this
to be checked at the call site.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
|
||
|---|---|---|
| .. | ||
| camss-csid-4-1.c | ||
| camss-csid-4-7.c | ||
| camss-csid-340.c | ||
| camss-csid-680.c | ||
| camss-csid-gen1.h | ||
| camss-csid-gen2.c | ||
| camss-csid-gen2.h | ||
| camss-csid-gen3.c | ||
| camss-csid-gen3.h | ||
| camss-csid.c | ||
| camss-csid.h | ||
| camss-csiphy-2ph-1-0.c | ||
| camss-csiphy-3ph-1-0.c | ||
| camss-csiphy.c | ||
| camss-csiphy.h | ||
| camss-format.c | ||
| camss-format.h | ||
| camss-ispif.c | ||
| camss-ispif.h | ||
| camss-vfe-4-1.c | ||
| camss-vfe-4-7.c | ||
| camss-vfe-4-8.c | ||
| camss-vfe-17x.c | ||
| camss-vfe-340.c | ||
| camss-vfe-480.c | ||
| camss-vfe-680.c | ||
| camss-vfe-gen1.c | ||
| camss-vfe-gen1.h | ||
| camss-vfe-gen3.c | ||
| camss-vfe-vbif.c | ||
| camss-vfe-vbif.h | ||
| camss-vfe.c | ||
| camss-vfe.h | ||
| camss-video.c | ||
| camss-video.h | ||
| camss.c | ||
| camss.h | ||
| Kconfig | ||
| Makefile | ||