github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-06 21:58:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

pinctrl: ambarella: fix NULL vs IS_ERR() bug in amb_pinctrl_register()

Browse Source 
The devm_kasprintf_strarray() function never returns NULL, it returns
error pointers on error or a valid pointer on success.  Fix the error
checking to match.

Fixes: b40e9d140c ("pinctrl: ambarella: add CV75 pin controller")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Dan Carpenter 2026-10-02 17:42:04 +03:00 committed by Linus Walleij
parent b89f7dd31a
commit 39b717b20c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/pinctrl-ambarella.c
View File

@ -426,8 +426,8 @@ static int amb_pinctrl_register(struct amb_pinctrl *ipc)
return -ENOMEM;
names = devm_kasprintf_strarray(ipc->dev, "io", ipc->data->npins);
if (!names)
return -ENOMEM;
if (IS_ERR(names))
return PTR_ERR(names);
for (unsigned int pin = 0; pin < ipc->data->npins; pin++) {
pindesc[pin].number = pin;