From 39b717b20c09028ee293b949a96325c0aa89a1a0 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 2 Oct 2026 17:42:04 +0300 Subject: [PATCH] pinctrl: ambarella: fix NULL vs IS_ERR() bug in amb_pinctrl_register() The devm_kasprintf_strarray() function never returns NULL, it returns error pointers on error or a valid pointer on success. Fix the error checking to match. Fixes: b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller") Signed-off-by: Dan Carpenter Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-ambarella.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ambarella.c b/drivers/pinctrl/pinctrl-ambarella.c index 83afef6a123f..5ed1010c5ce5 100644 --- a/drivers/pinctrl/pinctrl-ambarella.c +++ b/drivers/pinctrl/pinctrl-ambarella.c @@ -426,8 +426,8 @@ static int amb_pinctrl_register(struct amb_pinctrl *ipc) return -ENOMEM; names = devm_kasprintf_strarray(ipc->dev, "io", ipc->data->npins); - if (!names) - return -ENOMEM; + if (IS_ERR(names)) + return PTR_ERR(names); for (unsigned int pin = 0; pin < ipc->data->npins; pin++) { pindesc[pin].number = pin;