github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

pinctrl: starfive: fix missing CONFIG_OF dependencies

Browse Source 
The common driver portion requires CONFIG_OF, but the drivers
selecting it do not, so we get random warnings:

WARNING: unmet direct dependencies detected for PINCTRL_STARFIVE_JHB100
  Depends on [n]: PINCTRL [=y] && OF [=n]
  Selected by [y]:
  - PINCTRL_STARFIVE_JHB100_PER1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  - PINCTRL_STARFIVE_JHB100_PER2POK [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  - PINCTRL_STARFIVE_JHB100_SYS1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  Selected by [m]:
  - PINCTRL_STARFIVE_JHB100_PER0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
  - PINCTRL_STARFIVE_JHB100_SYS0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])

Apparently the problem is selecting CONFIG_OF_GPIO, which is a mistake
the newly added driver copied from others. This was recently cleaned up
with commit e785c990ad ("pinctrl: Kconfig: drop unneeded dependencies
on OF_GPIO"). Do the same here for consistency and to avoid the warning.

Fixes: 9c4d0c8fc4 ("pinctrl: starfive: Add StarFive JHB100 sys0 controller driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Arnd Bergmann 2026-10-02 14:47:15 +02:00 committed by Linus Walleij
parent 06a4459733
commit b89f7dd31a
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/starfive/Kconfig
View File

@ -50,11 +50,9 @@ config PINCTRL_STARFIVE_JH7110_AON
config PINCTRL_STARFIVE_JHB100
bool
depends on OF
select GENERIC_PINCTRL
select GPIOLIB
select GPIOLIB_IRQCHIP
select OF_GPIO
config PINCTRL_STARFIVE_JHB100_PER0
tristate "StarFive JHB100 SoC Peripheral-0 pinctrl and GPIO driver"