github-mirror/project-nomad
1
0
Fork 0
mirror of https://github.com/Crosstalk-Solutions/project-nomad.git synced 2026-04-03 23:36:17 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Docker): ensure containers fully removed on failed service install

Browse Source
This commit is contained in:
Jake Turner 2026-02-04 15:48:19 -08:00 committed by Jake Turner
parent a91c13867d
commit bfc6c3d113
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
admin/app/services/docker_service.ts
View File

@ -608,8 +608,7 @@ export class DockerService {
} }
const dockerContainer = this.docker.getContainer(container.Id) const dockerContainer = this.docker.getContainer(container.Id)
await dockerContainer.stop() await dockerContainer.remove({ force: true })
await dockerContainer.remove()
return { success: true, message: `Service ${serviceName} container removed successfully` } return { success: true, message: `Service ${serviceName} container removed successfully` }
} catch (error) { } catch (error) {
@ -678,6 +677,10 @@ export class DockerService {
await service.save() await service.save()
} }
this.activeInstallations.delete(serviceName) this.activeInstallations.delete(serviceName)
// Ensure any partially created container is removed
await this._removeServiceContainer(serviceName)
logger.info(`[DockerService] Cleaned up failed installation for ${serviceName}`) logger.info(`[DockerService] Cleaned up failed installation for ${serviceName}`)
} catch (error) { } catch (error) {
logger.error( logger.error(