From bfc6c3d113e8347e79c7c1304ef9c0d4fc098fca Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Wed, 4 Feb 2026 15:48:19 -0800 Subject: [PATCH] fix(Docker): ensure containers fully removed on failed service install --- admin/app/services/docker_service.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/admin/app/services/docker_service.ts b/admin/app/services/docker_service.ts index ed9949a..28cc928 100644 --- a/admin/app/services/docker_service.ts +++ b/admin/app/services/docker_service.ts @@ -608,8 +608,7 @@ export class DockerService { } const dockerContainer = this.docker.getContainer(container.Id) - await dockerContainer.stop() - await dockerContainer.remove() + await dockerContainer.remove({ force: true }) return { success: true, message: `Service ${serviceName} container removed successfully` } } catch (error) { @@ -678,6 +677,10 @@ export class DockerService { await service.save() } this.activeInstallations.delete(serviceName) + + // Ensure any partially created container is removed + await this._removeServiceContainer(serviceName) + logger.info(`[DockerService] Cleaned up failed installation for ${serviceName}`) } catch (error) { logger.error(