fix(editor): Wording for migration rule detail table headers (#22398)

This commit is contained in:
Guillaume Jacquart 2025-11-27 14:56:06 +01:00 committed by GitHub
parent 32c2909d72
commit cd9f56569d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 10 deletions

View File

@ -2816,16 +2816,14 @@
"settings.migrationReport.workflowsCount": "{count} Workflow | {count} Workflows",
"settings.migrationReport.detail.affectedTag": "{count} affected",
"settings.migrationReport.detail.table.name": "Name",
"settings.migrationReport.detail.table.issue": "Issue",
"settings.migrationReport.detail.table.status": "Status",
"settings.migrationReport.detail.table.active": "Active",
"settings.migrationReport.detail.table.deactivated": "Deactivated",
"settings.migrationReport.detail.table.nodeAffected": "Node affected",
"settings.migrationReport.detail.table.nodesAffected": "Nodes affected",
"settings.migrationReport.detail.table.numberOfExecutions": "Number of executions",
"settings.migrationReport.detail.table.lastExecuted": "Last executed",
"settings.migrationReport.detail.table.lastUpdated": "Last updated",
"settings.migrationReport.detail.table.never": "Never",
"settings.migrationReport.detail.table.active": "Active",
"settings.migrationReport.detail.table.deactivated": "Deactivated",
"settings.migrationReport.detail.search.placeholder": "Search workflows...",
"settings.migrationReport.detail.filter.status.label": "Status",
"settings.migrationReport.detail.filter.status.all": "All",

View File

@ -145,8 +145,8 @@ describe('MigrationRuleDetail', () => {
await waitFor(() => {
expect(screen.getByText('Name')).toBeInTheDocument();
expect(screen.getByText('Issue')).toBeInTheDocument();
expect(screen.getByText('Node affected')).toBeInTheDocument();
expect(screen.getByText('Status', { selector: 'th' })).toBeInTheDocument();
expect(screen.getByText('Nodes affected')).toBeInTheDocument();
expect(screen.getByText(/Number of executions/)).toBeInTheDocument();
expect(screen.getByText(/Last executed/)).toBeInTheDocument();
expect(screen.getByText(/Last updated/)).toBeInTheDocument();
@ -470,8 +470,8 @@ describe('MigrationRuleDetail', () => {
await waitFor(() => {
const dropdown = screen.getByTestId('resources-list-filters-dropdown');
expect(dropdown).toBeInTheDocument();
// Check that the status filter label is visible
expect(screen.getByText('Status')).toBeInTheDocument();
// Check that the status filter label is visible. Ignore 'th' elements to avoid confusion with table headers.
expect(screen.getByText('Status', { ignore: 'th' })).toBeInTheDocument();
});
});

View File

@ -60,7 +60,7 @@ const tableHeaders = ref<Array<TableHeader<AffectedWorkflow>>>([
width: 200,
},
{
title: i18n.baseText('settings.migrationReport.detail.table.issue'),
title: i18n.baseText('settings.migrationReport.detail.table.status'),
key: 'active',
value: (row: AffectedWorkflow) =>
row.active
@ -69,7 +69,7 @@ const tableHeaders = ref<Array<TableHeader<AffectedWorkflow>>>([
width: 40,
},
{
title: i18n.baseText('settings.migrationReport.detail.table.nodeAffected'),
title: i18n.baseText('settings.migrationReport.detail.table.nodesAffected'),
key: 'issues',
},
{