From cd9f56569dcf1e65df2d4f72b7007514276dac01 Mon Sep 17 00:00:00 2001 From: Guillaume Jacquart Date: Thu, 27 Nov 2025 14:56:06 +0100 Subject: [PATCH] fix(editor): Wording for migration rule detail table headers (#22398) --- packages/frontend/@n8n/i18n/src/locales/en.json | 6 ++---- .../settings/migrationReport/MigrationRuleDetail.test.ts | 8 ++++---- .../settings/migrationReport/MigrationRuleDetail.vue | 4 ++-- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/packages/frontend/@n8n/i18n/src/locales/en.json b/packages/frontend/@n8n/i18n/src/locales/en.json index f7b700fd1e5..c582b4f5016 100644 --- a/packages/frontend/@n8n/i18n/src/locales/en.json +++ b/packages/frontend/@n8n/i18n/src/locales/en.json @@ -2816,16 +2816,14 @@ "settings.migrationReport.workflowsCount": "{count} Workflow | {count} Workflows", "settings.migrationReport.detail.affectedTag": "{count} affected", "settings.migrationReport.detail.table.name": "Name", - "settings.migrationReport.detail.table.issue": "Issue", + "settings.migrationReport.detail.table.status": "Status", "settings.migrationReport.detail.table.active": "Active", "settings.migrationReport.detail.table.deactivated": "Deactivated", - "settings.migrationReport.detail.table.nodeAffected": "Node affected", + "settings.migrationReport.detail.table.nodesAffected": "Nodes affected", "settings.migrationReport.detail.table.numberOfExecutions": "Number of executions", "settings.migrationReport.detail.table.lastExecuted": "Last executed", "settings.migrationReport.detail.table.lastUpdated": "Last updated", "settings.migrationReport.detail.table.never": "Never", - "settings.migrationReport.detail.table.active": "Active", - "settings.migrationReport.detail.table.deactivated": "Deactivated", "settings.migrationReport.detail.search.placeholder": "Search workflows...", "settings.migrationReport.detail.filter.status.label": "Status", "settings.migrationReport.detail.filter.status.all": "All", diff --git a/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.test.ts b/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.test.ts index e5ef43a843e..062ed663785 100644 --- a/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.test.ts +++ b/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.test.ts @@ -145,8 +145,8 @@ describe('MigrationRuleDetail', () => { await waitFor(() => { expect(screen.getByText('Name')).toBeInTheDocument(); - expect(screen.getByText('Issue')).toBeInTheDocument(); - expect(screen.getByText('Node affected')).toBeInTheDocument(); + expect(screen.getByText('Status', { selector: 'th' })).toBeInTheDocument(); + expect(screen.getByText('Nodes affected')).toBeInTheDocument(); expect(screen.getByText(/Number of executions/)).toBeInTheDocument(); expect(screen.getByText(/Last executed/)).toBeInTheDocument(); expect(screen.getByText(/Last updated/)).toBeInTheDocument(); @@ -470,8 +470,8 @@ describe('MigrationRuleDetail', () => { await waitFor(() => { const dropdown = screen.getByTestId('resources-list-filters-dropdown'); expect(dropdown).toBeInTheDocument(); - // Check that the status filter label is visible - expect(screen.getByText('Status')).toBeInTheDocument(); + // Check that the status filter label is visible. Ignore 'th' elements to avoid confusion with table headers. + expect(screen.getByText('Status', { ignore: 'th' })).toBeInTheDocument(); }); }); diff --git a/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.vue b/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.vue index 422737c5df1..2026abe7d9c 100644 --- a/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.vue +++ b/packages/frontend/editor-ui/src/features/settings/migrationReport/MigrationRuleDetail.vue @@ -60,7 +60,7 @@ const tableHeaders = ref>>([ width: 200, }, { - title: i18n.baseText('settings.migrationReport.detail.table.issue'), + title: i18n.baseText('settings.migrationReport.detail.table.status'), key: 'active', value: (row: AffectedWorkflow) => row.active @@ -69,7 +69,7 @@ const tableHeaders = ref>>([ width: 40, }, { - title: i18n.baseText('settings.migrationReport.detail.table.nodeAffected'), + title: i18n.baseText('settings.migrationReport.detail.table.nodesAffected'), key: 'issues', }, {