github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-05-27 23:07:12 +02:00
Code Issues Actions 56 Packages Projects Releases Wiki Activity Graph

fix(core): Remove aggressive temp directory cleanup in binary data rename (#31068)
Some checks are pending
Build: Benchmark Image / build (push) Waiting to run
Details
CI: Master (Build, Test, Lint) / Build for Github Cache (push) Waiting to run
Details
CI: Master (Build, Test, Lint) / Unit tests (22.22.3) (push) Waiting to run
Details
CI: Master (Build, Test, Lint) / Unit tests (24.15.0) (push) Waiting to run
Details
CI: Master (Build, Test, Lint) / Lint (push) Waiting to run
Details
CI: Master (Build, Test, Lint) / Performance (push) Waiting to run
Details
CI: Master (Build, Test, Lint) / Notify Slack on failure (push) Blocked by required conditions
Details
Util: Sync API Docs / sync-public-api (push) Waiting to run
Details

Browse Source
This commit is contained in:
Tomi Turtiainen 2026-05-26 23:00:01 +03:00 committed by GitHub
parent 1f41d33852
commit 10a04cb209
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/core/src/binary-data/__tests__/file-system.manager.test.ts
View File

@ -207,7 +207,7 @@ describe('deleteMany()', () => {
});
describe('rename()', () => {
it('should rename a file', async () => {
it('should rename a file without deleting the temp directory', async () => {
fsp.rename = jest.fn().mockResolvedValue(undefined);
fsp.rm = jest.fn().mockResolvedValue(undefined);
@ -221,5 +221,6 @@ describe('rename()', () => {
expect(fsp.rename).toHaveBeenCalledTimes(2);
expect(fsp.rename).toHaveBeenCalledWith(oldPath, newPath);
expect(fsp.rename).toHaveBeenCalledWith(`${oldPath}.metadata`, `${newPath}.metadata`);
expect(fsp.rm).not.toHaveBeenCalled();
});
});

5
packages/core/src/binary-data/file-system.manager.ts
View File

@ -131,11 +131,6 @@ export class FileSystemManager implements BinaryData.Manager {
fs.rename(oldPath, newPath),
fs.rename(`${oldPath}.metadata`, `${newPath}.metadata`),
]);
const [tempDirParent] = oldPath.split('/temp/');
const tempDir = path.join(tempDirParent, 'temp');
await fs.rm(tempDir, { recursive: true });
}
async deleteManyByFileId(ids: string[]): Promise<void> {