From 10a04cb209bc7860d6db561ecfe7d236dfb308b2 Mon Sep 17 00:00:00 2001 From: Tomi Turtiainen <10324676+tomi@users.noreply.github.com> Date: Tue, 26 May 2026 23:00:01 +0300 Subject: [PATCH] fix(core): Remove aggressive temp directory cleanup in binary data rename (#31068) --- .../src/binary-data/__tests__/file-system.manager.test.ts | 3 ++- packages/core/src/binary-data/file-system.manager.ts | 5 ----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/core/src/binary-data/__tests__/file-system.manager.test.ts b/packages/core/src/binary-data/__tests__/file-system.manager.test.ts index 2735555d35e..58b4fde52fb 100644 --- a/packages/core/src/binary-data/__tests__/file-system.manager.test.ts +++ b/packages/core/src/binary-data/__tests__/file-system.manager.test.ts @@ -207,7 +207,7 @@ describe('deleteMany()', () => { }); describe('rename()', () => { - it('should rename a file', async () => { + it('should rename a file without deleting the temp directory', async () => { fsp.rename = jest.fn().mockResolvedValue(undefined); fsp.rm = jest.fn().mockResolvedValue(undefined); @@ -221,5 +221,6 @@ describe('rename()', () => { expect(fsp.rename).toHaveBeenCalledTimes(2); expect(fsp.rename).toHaveBeenCalledWith(oldPath, newPath); expect(fsp.rename).toHaveBeenCalledWith(`${oldPath}.metadata`, `${newPath}.metadata`); + expect(fsp.rm).not.toHaveBeenCalled(); }); }); diff --git a/packages/core/src/binary-data/file-system.manager.ts b/packages/core/src/binary-data/file-system.manager.ts index 04624cedec3..b335c3c6f3e 100644 --- a/packages/core/src/binary-data/file-system.manager.ts +++ b/packages/core/src/binary-data/file-system.manager.ts @@ -131,11 +131,6 @@ export class FileSystemManager implements BinaryData.Manager { fs.rename(oldPath, newPath), fs.rename(`${oldPath}.metadata`, `${newPath}.metadata`), ]); - - const [tempDirParent] = oldPath.split('/temp/'); - const tempDir = path.join(tempDirParent, 'temp'); - - await fs.rm(tempDir, { recursive: true }); } async deleteManyByFileId(ids: string[]): Promise {