mirror of
https://github.com/torvalds/linux.git
synced 2026-10-28 17:55:02 +01:00
5cc65c01cd
mtk_pcs_lynxi_get_state() ignores regmap_read()'s return value; a failed read leaves bm and adv holding uninitialized stack values which are then decoded into the reported link state. The regmaps backing the MT7531 SGMII PCS instances sit on an MDIO bus where reads can fail. Check both reads and report the link as down on error; phylink presets state->link before the callback, so a bare return would leave a failed read reported as link-up. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/fce70657fc03bbaf60a04c0fbf2f418531135c4f.1785811140.git.daniel@makrotopia.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| pcs-lynx.c | ||
| pcs-mtk-lynxi.c | ||
| pcs-rzn1-miic.c | ||
| pcs-xpcs-nxp.c | ||
| pcs-xpcs-plat.c | ||
| pcs-xpcs-wx.c | ||
| pcs-xpcs.c | ||
| pcs-xpcs.h | ||