linux/drivers/gpu/drm/msm
Nathan Chancellor 53676e4d44 drm/msm: Restore second parameter name in purge() and evict()
After commit 3392291fc5 ("drm/msm: Fix shrinker deadlock"), all
supported versions of clang warn (or error with CONFIG_WERROR=y):

  drivers/gpu/drm/msm/msm_gem_shrinker.c:105:58: error: omitting the parameter name in a function definition is a C23 extension [-Werror,-Wc23-extensions]
    105 | purge(struct drm_gem_object *obj, struct ww_acquire_ctx *)
        |                                                          ^
  drivers/gpu/drm/msm/msm_gem_shrinker.c:117:58: error: omitting the parameter name in a function definition is a C23 extension [-Werror,-Wc23-extensions]
    117 | evict(struct drm_gem_object *obj, struct ww_acquire_ctx *)
        |                                                          ^
  2 errors generated.

With older but supported versions of GCC, this is an unconditional hard error:

  drivers/gpu/drm/msm/msm_gem_shrinker.c: In function 'purge':
  drivers/gpu/drm/msm/msm_gem_shrinker.c:105:35: error: parameter name omitted
   purge(struct drm_gem_object *obj, struct ww_acquire_ctx *)
                                     ^~~~~~~~~~~~~~~~~~~~~~~
  drivers/gpu/drm/msm/msm_gem_shrinker.c: In function 'evict':
  drivers/gpu/drm/msm/msm_gem_shrinker.c:117:35: error: parameter name omitted
   evict(struct drm_gem_object *obj, struct ww_acquire_ctx *)
                                     ^~~~~~~~~~~~~~~~~~~~~~~

Restore the parameter name to clear up the warnings, renaming it
"unused" to make it clear it is only needed to satisfy the prototype of
drm_gem_lru_scan().

Cc: stable@vger.kernel.org
Fixes: 3392291fc5 ("drm/msm: Fix shrinker deadlock")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2026-05-24 10:31:24 -07:00
..
adreno Merge tag 'drm-msm-fixes-2026-05-17' of https://gitlab.freedesktop.org/drm/msm into drm-fixes 2026-05-21 10:12:22 +10:00
disp Merge tag 'drm-msm-fixes-2026-05-17' of https://gitlab.freedesktop.org/drm/msm into drm-fixes 2026-05-21 10:12:22 +10:00
dp Merge tag 'drm-msm-next-2026-04-02' of https://gitlab.freedesktop.org/drm/msm into drm-next 2026-04-03 18:57:00 +10:00
dsi drm/msm/dsi: don't dump registers past the mapped region 2026-05-13 16:18:35 +03:00
hdmi Merge tag 'drm-msm-next-2026-04-02' of https://gitlab.freedesktop.org/drm/msm into drm-next 2026-04-03 18:57:00 +10:00
registers drm/msm/a6xx: Add soft fuse detection support 2026-03-31 13:47:30 -07:00
.gitignore
Kconfig drm/msm: rearrange symbol selection 2025-07-05 07:13:35 -07:00
Makefile drm/msm/a8xx: Preemption support for A840 2026-03-31 13:47:30 -07:00
msm_atomic_trace.h
msm_atomic_tracepoints.c
msm_atomic.c
msm_debugfs.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
msm_debugfs.h
msm_drv.c drm/gem: Make the GEM LRU lock part of drm_device 2026-05-18 15:16:47 +02:00
msm_drv.h drm/gem: Make the GEM LRU lock part of drm_device 2026-05-18 15:16:47 +02:00
msm_dsc_helper.h
msm_fb.c Merge tag 'drm-msm-next-2026-04-02' of https://gitlab.freedesktop.org/drm/msm into drm-next 2026-04-03 18:57:00 +10:00
msm_fbdev.c drm/fb-helper: Allocate and release fb_info in single place 2025-11-25 11:02:43 +01:00
msm_fence.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
msm_fence.h drm/msm: msm_fence.h: fix all kernel-doc warnings 2025-12-24 11:24:19 +02:00
msm_gem_prime.c drm/msm: Fix 32b size truncation 2025-09-06 08:58:11 -07:00
msm_gem_shrinker.c drm/msm: Restore second parameter name in purge() and evict() 2026-05-24 10:31:24 -07:00
msm_gem_submit.c drm/gem: Make the GEM LRU lock part of drm_device 2026-05-18 15:16:47 +02:00
msm_gem_vma.c drm/gem: Make the GEM LRU lock part of drm_device 2026-05-18 15:16:47 +02:00
msm_gem.c drm/gem: Make the GEM LRU lock part of drm_device 2026-05-18 15:16:47 +02:00
msm_gem.h Merge tag 'drm-msm-next-2026-04-02' of https://gitlab.freedesktop.org/drm/msm into drm-next 2026-04-03 18:57:00 +10:00
msm_gpu_devfreq.c
msm_gpu_trace.h drm/msm: Add an ftrace for gpu register access 2025-09-08 07:24:59 -07:00
msm_gpu_tracepoints.c
msm_gpu.c Merge tag 'drm-msm-fixes-2026-05-17' of https://gitlab.freedesktop.org/drm/msm into drm-fixes 2026-05-21 10:12:22 +10:00
msm_gpu.h drm/msm: msm_gpu.h: fix all kernel-doc warnings 2025-12-24 11:24:19 +02:00
msm_io_utils.c
msm_iommu.c Merge tag 'drm-msm-fixes-2026-05-17' of https://gitlab.freedesktop.org/drm/msm into drm-fixes 2026-05-21 10:12:22 +10:00
msm_kms.c treewide: Replace kmalloc with kmalloc_obj for non-scalar types 2026-02-21 01:02:28 -08:00
msm_kms.h drm/msm: make it possible to disable KMS-related code. 2025-07-05 07:13:35 -07:00
msm_mdss.c drm/msm/mdss: Add a TODO for better managing the MDSS clock power state 2026-03-25 08:06:09 +02:00
msm_mmu.h drm/msm: Support pgtable preallocation 2025-07-04 17:48:37 -07:00
msm_perf.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
msm_rd.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
msm_ringbuffer.c drm/gem: Make the GEM LRU lock part of drm_device 2026-05-18 15:16:47 +02:00
msm_ringbuffer.h
msm_submitqueue.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
msm_syncobj.c treewide: Replace kmalloc with kmalloc_obj for non-scalar types 2026-02-21 01:02:28 -08:00
msm_syncobj.h drm/msm: Extract out syncobj helpers 2025-07-04 17:48:37 -07:00
NOTES