linux/drivers/net/ethernet/wangxun/txgbe
Jiawen Wu c263f644ad net: txgbe: fix firmware version check
For the device SP, the firmware version is a 32-bit value where the
lower 20 bits represent the base version number. And the customized
firmware version populates the upper 12 bits with a specific
identification number.

For other devices AML 25G and 40G, the upper 12 bits of the firmware
version is always non-zero, and they have other naming conventions.

Only SP devices need to check this to tell if XPCS will work properly.
So the judgement of MAC type is added here.

And the original logic compared the entire 32-bit value against 0x20010,
which caused the outdated base firmwares bypass the version check
without a warning. Apply a mask 0xfffff to isolate the lower 20 bits for
an accurate base version comparison.

Fixes: ab928c24e6 ("net: txgbe: add FW version warning")
Cc: stable@vger.kernel.org
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/C787AA5C07598B13+20260422071837.372731-1-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2026-04-23 12:02:59 -07:00
..
Makefile net: txgbe: Implement PHYLINK for AML 25G/10G devices 2025-05-26 17:25:42 +02:00
txgbe_aml.c net: txgbe: remove the redundant data return in SW-FW mailbox 2026-01-20 18:35:56 -08:00
txgbe_aml.h net: txgbe: support getting module EEPROM by page 2025-11-20 12:47:26 +01:00
txgbe_ethtool.c net: wangxun: move ethtool_ops.set_channels into libwx 2026-04-12 08:42:28 -07:00
txgbe_ethtool.h net: txgbe: Correct the currect link settings 2025-05-26 17:25:42 +02:00
txgbe_fdir.c net: txgbe: Support the FDIR rules assigned to VFs 2025-05-27 18:17:11 -07:00
txgbe_fdir.h net: txgbe: support Flow Director perfect filters 2024-06-20 13:18:54 +02:00
txgbe_hw.c net: txgbe: Remove specified SP type 2025-05-26 17:25:41 +02:00
txgbe_hw.h net: wangxun: remove redundant kernel log 2023-10-18 17:57:36 -07:00
txgbe_irq.c net: txgbe: improve functions of AML 40G devices 2025-11-20 12:47:26 +01:00
txgbe_irq.h net: txgbe: remove separate irq request for MSI and INTx 2024-07-02 16:07:04 +02:00
txgbe_main.c net: txgbe: fix firmware version check 2026-04-23 12:02:59 -07:00
txgbe_phy.c net: txgbe: fix RTNL assertion warning when remove module 2026-04-09 20:33:43 -07:00
txgbe_phy.h net: wangxun: Correct clerical errors in comments 2025-05-14 09:47:33 +01:00
txgbe_type.h net: txgbe: leave space for null terminators on property_entry 2026-04-08 19:11:37 -07:00