mirror of
https://github.com/torvalds/linux.git
synced 2026-10-16 12:50:02 +02:00
7f85d11705
The struct f81604_int_data defines 9 bytes of interrupt data:
- Byte 0: Status register (sr)
- Byte 1: Interrupt register (isrc)
- Byte 2: Interrupt enable register (ier)
- Byte 3: Arbitration lost capture (alc)
- Byte 4: Error code capture (ecc)
- Byte 5: Error warning limit register (ewlr)
- Byte 6: RX error counter (rxerr)
- Byte 7: TX error counter (txerr)
- Byte 8: Reserved (val)
The hardware sends exactly 9 bytes for the interrupt endpoint.
However, the struct was defined with __aligned(4) attribute which
caused the compiler to pad the struct to 12 bytes.
This causes a problem in f81604_read_int_callback() where the short
URB check compares urb->actual_length against sizeof(*data). When
sizeof(struct f81604_int_data) is 12 but the hardware only sends 9
bytes, the check fails and valid interrupt messages are discarded.
This results in the driver only being able to transmit once because
the TX complete interrupt is never processed.
Fix this by removing the __aligned(4) attribute so the struct size
matches the actual hardware data size of 9 bytes.
Fixes:
|
||
|---|---|---|
| .. | ||
| c_can | ||
| cc770 | ||
| ctucanfd | ||
| dev | ||
| esd | ||
| flexcan | ||
| ifi_canfd | ||
| kvaser_pciefd | ||
| m_can | ||
| mscan | ||
| peak_canfd | ||
| rcar | ||
| rockchip | ||
| sja1000 | ||
| slcan | ||
| softing | ||
| spi | ||
| usb | ||
| at91_can.c | ||
| bxcan.c | ||
| can327.c | ||
| dummy_can.c | ||
| grcan.c | ||
| janz-ican3.c | ||
| Kconfig | ||
| Makefile | ||
| sun4i_can.c | ||
| ti_hecc.c | ||
| vcan.c | ||
| virtio_can.c | ||
| vxcan.c | ||
| xilinx_can.c | ||