github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

apparmor: Fix the return value in split_token_from_name() kernel-doc

Browse Source 
split_token_from_name() returns ERR_PTR(-EINVAL) for malformed input,
but its kernel-doc describes NULL as the failure result. NULL is instead
a successful result when the name following the token is empty.

Document all three results: the name, NULL for an empty name, and an
error pointer for malformed input.

Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
This commit is contained in:
Karl Mehltretter 2026-09-12 02:03:02 +02:00 committed by John Johansen
parent e667fc72f7
commit fcd621debf
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
security/apparmor/procattr.c
View File

@ -74,7 +74,8 @@ int aa_getprocattr(struct aa_label *label, char **string, bool newline)
* @args: string to parse (NOT NULL)
* @token: stores returned parsed token value (NOT NULL)
*
* Returns: start position of name after token else NULL on failure
* Returns: the name following the token, %NULL if the name is empty, or
* ERR_PTR(-EINVAL) if the input is malformed.
*/
static char *split_token_from_name(const char *op, char *args, u64 *token)
{