From fcd621debff51f09cc665e1063a6025d7c1bfd48 Mon Sep 17 00:00:00 2001 From: Karl Mehltretter Date: Sat, 12 Sep 2026 02:03:02 +0200 Subject: [PATCH] apparmor: Fix the return value in split_token_from_name() kernel-doc split_token_from_name() returns ERR_PTR(-EINVAL) for malformed input, but its kernel-doc describes NULL as the failure result. NULL is instead a successful result when the name following the token is empty. Document all three results: the name, NULL for an empty name, and an error pointer for malformed input. Assisted-by: LLM Signed-off-by: Karl Mehltretter Signed-off-by: John Johansen --- security/apparmor/procattr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/apparmor/procattr.c b/security/apparmor/procattr.c index c07b6e8fd9c9..cfc45db43aa0 100644 --- a/security/apparmor/procattr.c +++ b/security/apparmor/procattr.c @@ -74,7 +74,8 @@ int aa_getprocattr(struct aa_label *label, char **string, bool newline) * @args: string to parse (NOT NULL) * @token: stores returned parsed token value (NOT NULL) * - * Returns: start position of name after token else NULL on failure + * Returns: the name following the token, %NULL if the name is empty, or + * ERR_PTR(-EINVAL) if the input is malformed. */ static char *split_token_from_name(const char *op, char *args, u64 *token) {