github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 01:55:51 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config()

Browse Source 
The devm_memremap() function doesn't return NULL, it returns error
pointers.  Fix the error checking to match.

Fixes: ac23106a9b ("soc: qcom: llcc-qcom: get SCT descriptors from fw-populated memory")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/ag1N_rAHEQ1YJsa7@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
This commit is contained in:
Dan Carpenter 2026-05-20 09:00:30 +03:00 committed by Bjorn Andersson
parent 0a4d53ae2c
commit db0ec1ad72
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/soc/qcom/llcc-qcom.c
View File

@ -5410,9 +5410,9 @@ static int qcom_llcc_get_fw_config(struct platform_device *pdev)
}
slc_mem = devm_memremap(dev, res.start, resource_size(&res), MEMREMAP_WB);
if (!slc_mem) {
if (IS_ERR(slc_mem)) {
dev_err(dev, "Failed to memremap SLC shared memory\n");
return -ENOMEM;
return PTR_ERR(slc_mem);
}
ret = qcom_llcc_verify_fw_config(dev, slc_mem);