From db0ec1ad723187a3428145b05d4a230d5b6f7e32 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 20 May 2026 09:00:30 +0300 Subject: [PATCH] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config() The devm_memremap() function doesn't return NULL, it returns error pointers. Fix the error checking to match. Fixes: ac23106a9b9a ("soc: qcom: llcc-qcom: get SCT descriptors from fw-populated memory") Signed-off-by: Dan Carpenter Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/ag1N_rAHEQ1YJsa7@stanley.mountain Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/llcc-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 1359c7b2d41b..8948b5fd42d2 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -5410,9 +5410,9 @@ static int qcom_llcc_get_fw_config(struct platform_device *pdev) } slc_mem = devm_memremap(dev, res.start, resource_size(&res), MEMREMAP_WB); - if (!slc_mem) { + if (IS_ERR(slc_mem)) { dev_err(dev, "Failed to memremap SLC shared memory\n"); - return -ENOMEM; + return PTR_ERR(slc_mem); } ret = qcom_llcc_verify_fw_config(dev, slc_mem);