github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-23 05:04:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

HID: steam: Don't set feature reports when disconnecting

Browse Source 
When an input device is closed, we set a feature report to reset lizard
mode and IMU mode. However, if the input device is closed because it was
removed, then we will necessarily error out when sending this, resulting in
logged errors. Since an error here is expected, we should just fail
silently.

Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Vicki Pfau 2026-08-11 18:13:55 -07:00 committed by Jiri Kosina
parent 0a0028c2aa
commit cfa66cba6d
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/hid/hid-steam.c
View File

@ -490,9 +490,13 @@ static int steam_recv_report_id(struct steam_device *steam,
}
kfree(buf);
if (ret < 0)
/*
* Don't log if the failure is -ENODEV, as this
* can happen normally on disconnect.
*/
if (ret < 0 && ret != -ENODEV)
hid_err(steam->hdev, "%s: error %d\n", __func__, ret);
else
else if (ret > 0)
hid_dbg(steam->hdev, "Received report %*ph\n", size, data);
if (ret < 0)
return ret;
@ -557,7 +561,11 @@ static int steam_send_report_id(struct steam_device *steam,
} while (--retries);
kfree(buf);
if (ret < 0)
/*
* Don't log if the failure is -ENODEV, as this
* can happen normally on disconnect.
*/
if (ret < 0 && ret != -ENODEV)
hid_err(steam->hdev, "%s: error %d (%*ph)\n", __func__,
ret, size, cmd);
return ret;