rtla/tests: Test actions in absence of threshold

Commit fafb66e590 ("rtla/timerlat_top: Fix on-threshold actions firing
on signal") fixed a bug where on-threshold actions were being triggered
even without a threshold being set.

Test all four tools with an --on-threshold action, but with no set
threshold, and verify the action does not trigger.

Link: https://lore.kernel.org/r/20260807094555.1244103-1-tglozar@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
This commit is contained in:
Tomas Glozar 2026-08-07 11:45:55 +02:00
parent 93f51579e7
commit c6bafe09bf
2 changed files with 4 additions and 0 deletions

View File

@ -98,5 +98,7 @@ check_top_q_hist "with conditional continue" \
"osnoise TOOL -S 2 --on-threshold shell,command='if [ -f a ]; then echo 2; exit 1; else echo -n 1; touch a; fi' --on-threshold continue" 2 "^12$" "^2$"
check_top_hist "with trace output at end" \
"osnoise TOOL -d 1s --on-end trace" 0 "^ Saving trace to osnoise_trace.txt$"
check_top_q_hist "action with no threshold" \
"osnoise TOOL -d 1s --on-threshold shell,command='echo BAD'" 0 "" "BAD"
test_end

View File

@ -136,6 +136,8 @@ check_top_q_hist "with conditional continue" \
"timerlat TOOL -T 2 --on-threshold shell,command='if [ -f a ]; then echo 2; exit 1; else echo -n 1; touch a; fi' --on-threshold continue" 2 "^12$" "^2$"
check_top_hist "with trace output at end" \
"timerlat TOOL -d 1s --on-end trace" 0 "^ Saving trace to timerlat_trace.txt$"
check_top_q_hist "action with no threshold" \
"timerlat TOOL -d 1s --on-threshold shell,command='echo BAD'" 0 "" "BAD"
# BPF action program tests
if [ "$option" -eq 0 ]