From c6bafe09bf536e01017b8bd77dcacf4f04069c48 Mon Sep 17 00:00:00 2001 From: Tomas Glozar Date: Fri, 7 Aug 2026 11:45:55 +0200 Subject: [PATCH] rtla/tests: Test actions in absence of threshold Commit fafb66e5903c ("rtla/timerlat_top: Fix on-threshold actions firing on signal") fixed a bug where on-threshold actions were being triggered even without a threshold being set. Test all four tools with an --on-threshold action, but with no set threshold, and verify the action does not trigger. Link: https://lore.kernel.org/r/20260807094555.1244103-1-tglozar@redhat.com Signed-off-by: Tomas Glozar --- tools/tracing/rtla/tests/osnoise.t | 2 ++ tools/tracing/rtla/tests/timerlat.t | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/tracing/rtla/tests/osnoise.t b/tools/tracing/rtla/tests/osnoise.t index 214fd40fc610..352b30237245 100644 --- a/tools/tracing/rtla/tests/osnoise.t +++ b/tools/tracing/rtla/tests/osnoise.t @@ -98,5 +98,7 @@ check_top_q_hist "with conditional continue" \ "osnoise TOOL -S 2 --on-threshold shell,command='if [ -f a ]; then echo 2; exit 1; else echo -n 1; touch a; fi' --on-threshold continue" 2 "^12$" "^2$" check_top_hist "with trace output at end" \ "osnoise TOOL -d 1s --on-end trace" 0 "^ Saving trace to osnoise_trace.txt$" +check_top_q_hist "action with no threshold" \ + "osnoise TOOL -d 1s --on-threshold shell,command='echo BAD'" 0 "" "BAD" test_end diff --git a/tools/tracing/rtla/tests/timerlat.t b/tools/tracing/rtla/tests/timerlat.t index 5116857d7da4..1d317c851a0f 100644 --- a/tools/tracing/rtla/tests/timerlat.t +++ b/tools/tracing/rtla/tests/timerlat.t @@ -136,6 +136,8 @@ check_top_q_hist "with conditional continue" \ "timerlat TOOL -T 2 --on-threshold shell,command='if [ -f a ]; then echo 2; exit 1; else echo -n 1; touch a; fi' --on-threshold continue" 2 "^12$" "^2$" check_top_hist "with trace output at end" \ "timerlat TOOL -d 1s --on-end trace" 0 "^ Saving trace to timerlat_trace.txt$" +check_top_q_hist "action with no threshold" \ + "timerlat TOOL -d 1s --on-threshold shell,command='echo BAD'" 0 "" "BAD" # BPF action program tests if [ "$option" -eq 0 ]