github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-31 18:43:33 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

btrfs: replace BUG() with error handling in __btrfs_balance()

Browse Source 
We search with offset (u64)-1 which should never match exactly.
Previously this was handled with BUG(). Now logs an error
and return -EUCLEAN.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Adarsh Das 2026-02-03 22:53:57 +05:30 committed by David Sterba
parent 1c88823a19
commit be6324a809
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/btrfs/volumes.c
View File

@ -4367,8 +4367,14 @@ static int __btrfs_balance(struct btrfs_fs_info *fs_info)
* this shouldn't happen, it means the last relocate * this shouldn't happen, it means the last relocate
* failed * failed
*/ */
if (ret == 0) if (unlikely(ret == 0)) {
BUG(); /* FIXME break ? */ btrfs_err(fs_info,
"unexpected exact match of CHUNK_ITEM in chunk tree, offset 0x%llx",
key.offset);
mutex_unlock(&fs_info->reclaim_bgs_lock);
ret = -EUCLEAN;
goto error;
}
ret = btrfs_previous_item(chunk_root, path, 0, ret = btrfs_previous_item(chunk_root, path, 0,
BTRFS_CHUNK_ITEM_KEY); BTRFS_CHUNK_ITEM_KEY);