github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-01 11:03:43 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

btrfs: handle unexpected exact match in btrfs_set_inode_index_count()

Browse Source 
We search with offset (u64)-1 which should never match exactly.
Previously the code silently returned success without setting the index
count. Now logs an error and return -EUCLEAN instead.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>,
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Adarsh Das 2026-02-03 22:53:56 +05:30 committed by David Sterba
parent 161ab30da6
commit 1c88823a19
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
fs/btrfs/inode.c
View File

@ -6149,9 +6149,18 @@ static int btrfs_set_inode_index_count(struct btrfs_inode *inode)
ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
if (ret < 0)
return ret;
/* FIXME: we should be able to handle this */
if (ret == 0)
return ret;
if (unlikely(ret == 0)) {
/*
* Key with offset -1 found, there would have to exist a dir
* index item with such offset, but this is out of the valid
* range.
*/
btrfs_err(root->fs_info,
"unexpected exact match for DIR_INDEX key, inode %llu",
btrfs_ino(inode));
return -EUCLEAN;
}
if (path->slots[0] == 0) {
inode->index_cnt = BTRFS_DIR_START_INDEX;