github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

dmaengine: amlogic: Fix regmap error check issue

Browse Source 
The func devm_regmap_init_mmio() only returns an error pointer on failure,
Use IS_ERR() instead to make the intent clearer. And Fix the following
compilation issue at the same time.

Smatch warnings:
drivers/dma/amlogic-dma.c:636 aml_dma_probe() warn: passing zero to 'PTR_ERR'

Fixes: b84b5197e3 ("dmaengine: amlogic: Add general DMA driver for A9")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202610080953.C5TYlCaA-lkp@intel.com/
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20261016-fix-a9-dma-complier-v1-1-024421d5b3c8@amlogic.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Xianwei Zhao 2026-10-16 03:00:17 +00:00 committed by Vinod Koul
parent 42c31fec1c
commit aff5e6a77f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/dma/amlogic-dma.c
View File

@ -632,7 +632,7 @@ static int aml_dma_probe(struct platform_device *pdev)
aml_dma->regmap = devm_regmap_init_mmio(&pdev->dev, aml_dma->base,
&aml_regmap_config);
if (IS_ERR_OR_NULL(aml_dma->regmap))
if (IS_ERR(aml_dma->regmap))
return PTR_ERR(aml_dma->regmap);
aml_dma->clk = devm_clk_get_enabled(&pdev->dev, NULL);