From aff5e6a77fc69a7c490246465940d18422d7c631 Mon Sep 17 00:00:00 2001 From: Xianwei Zhao Date: Fri, 16 Oct 2026 03:00:17 +0000 Subject: [PATCH] dmaengine: amlogic: Fix regmap error check issue The func devm_regmap_init_mmio() only returns an error pointer on failure, Use IS_ERR() instead to make the intent clearer. And Fix the following compilation issue at the same time. Smatch warnings: drivers/dma/amlogic-dma.c:636 aml_dma_probe() warn: passing zero to 'PTR_ERR' Fixes: b84b5197e344 ("dmaengine: amlogic: Add general DMA driver for A9") Reported-by: kernel test robot Closes: https://lore.kernel.org/r/202610080953.C5TYlCaA-lkp@intel.com/ Reported-by: Dan Carpenter Signed-off-by: Xianwei Zhao Reviewed-by: Frank Li Link: https://patch.msgid.link/20261016-fix-a9-dma-complier-v1-1-024421d5b3c8@amlogic.com Signed-off-by: Vinod Koul --- drivers/dma/amlogic-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/amlogic-dma.c b/drivers/dma/amlogic-dma.c index 78ee2337ae71..684121d13fca 100644 --- a/drivers/dma/amlogic-dma.c +++ b/drivers/dma/amlogic-dma.c @@ -632,7 +632,7 @@ static int aml_dma_probe(struct platform_device *pdev) aml_dma->regmap = devm_regmap_init_mmio(&pdev->dev, aml_dma->base, &aml_regmap_config); - if (IS_ERR_OR_NULL(aml_dma->regmap)) + if (IS_ERR(aml_dma->regmap)) return PTR_ERR(aml_dma->regmap); aml_dma->clk = devm_clk_get_enabled(&pdev->dev, NULL);