i.MX clock changes for 7.3

- Add audio PLL debugfs support for K-divider control.
 - Add missing MODULE_DEVICE_TABLE() declarations for i.MX8QXP clock drivers.
 - Add PCIe FUNC_OUTPUT_EN clock gate support on i.MX95.
 - Configure the i.MX95 PCIe transmitter current reference to fix REFCLK
   rise-fall timing.
 -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEETvPuEU56jyrKp9G4G19EyQCVFVYFAmpxz1YACgkQG19EyQCV
 FVYqmA/7BUS8H0KGRHeRs2VXP1tAydexeUgePx0eqzUzSij92rSicZodfhMeuVtt
 9k3MH35QFRiiKcU9giOFg7XQk5KEAXwsLFuoaPv5EYwITChKeTCKhOu42GvQ5BMA
 sTvuENQt9rg3oW3wGfluiWK/ENxboB3TlbV/mCU2YuNdpwHnKRDu6lqWFn2milx1
 j31izCzrXDndFD3Iw6KRnnAyzS6TBO55iXOSvWJe15XepHERXn73m/0IW+4ZsAMY
 dp9ggS4Qo68qczPxQQv2mudntSpz++ZUoAJbCuYHppgstUOpS/9lFm3w5EpRa7MR
 TTy6p1sKhddM0l463Lct6nDXFSXUzhk5cAmF3BSGdF3rJf3nkGRWTmyEXkW2TzPY
 Qedg9wU4hDEygMqd4Mk2Tpd1GNIUxAuwD6J0sa4janh2kCTfVo/B1NruW6rERSfL
 6AmFVwSSdjo9z8OYXNn+nzpycvdC4EVZr4tUzm14mjou05LBSy0Q4kUJredQpuJt
 w7yjBa4j8Y3DtY80sQ6yBjFn06T9wmx0SdpNp01sYODzF4p5B4hSt/IJqG6RFiu5
 /B2pNWRFsgys0KGky/IVcqfYhjnyuiV+yDJortnryVGHMa9XmeEwLkvJyhg8FTs4
 FkU5INkvjL92jZohpgCjNjSbYFyn1HoSH6Bu5x1P1iGDCkdaYhs=
 =AFza
 -----END PGP SIGNATURE-----
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQJIBAABCAAyFiEE9L57QeeUxqYDyoaDrQKIl8bklSUFAmp8CGcUHHN3Ym95ZEBj
 aHJvbWl1bS5vcmcACgkQrQKIl8bklSUNgBAAoJnoiA+XxAtdiqS0ESsjrzsGN8y3
 2p2nGLioG8feIoGlSQ5G8rWBH3nCsDh7fjr7dqUwKnBOWXgaR858ypVnBOeYKXKI
 4BMhI7GAkhN94fGUkRcM1OXmddQ/0o03Tus0c9YkaQeQ5oXoAWbGMTHprqXAWE9D
 7fGzcv3JpvpbMI1hucqDDi7XXkNWnzD41sysPMfdUpcX5gqHANtPWE8A1Onq/9nK
 q6NKkiIeQ/rBlnNLhJsKJWNGrC7Bc9tSWiAsntNyEfxywtghRsTyzDQ3Eo1YIIzG
 UaD3tNeoGk7aanWYkQHjnL6RCWLKUElfBlhPAvW0Lm9T93K5CaoUOvT9oFJVVnO6
 KbMEKdfKjhdhGmGrU+bujchGxsl90rpQEOS4xuZUNU3nUFw1h3GvkkPl+Nt+bJIz
 Io/qzbQrhcMLni7aP2POZa6hHKcOkCzDm/b5+OmYFXDGK+x6MvkhcgXVEov4gM1f
 bgFshkyi8JHS+wrEHf+gshvoF9aVMu/V7JsZm+zQBh7Z48neRPfkPkx3WLimv1K/
 2d1jkEgIKpY6+z5095/kS4H7/oAK94zaODuBc3VjOAw/3MbLU0j1y8s0o1NcS4Bc
 iHj5OIZ++V1EigGtp6aiPkUJud0Pl8U4nrdVxa/o/MeMq8bgyxub/9G8lm/BRDB+
 idO7CpOqwJLKLko=
 =YBxi
 -----END PGP SIGNATURE-----

Merge tag 'clk-imx-7.3' of git://git.kernel.org/pub/scm/linux/kernel/git/abelvesa/linux into clk-imx

Pull i.MX clk driver updates from Abel Vesa:

 - Add audio PLL debugfs support for K-divider control.
 - Add missing MODULE_DEVICE_TABLE() declarations for i.MX8QXP clock drivers.
 - Add PCIe FUNC_OUTPUT_EN clock gate support on i.MX95.
 - Configure the i.MX95 PCIe transmitter current reference to fix REFCLK
   rise-fall timing.

* tag 'clk-imx-7.3' of git://git.kernel.org/pub/scm/linux/kernel/git/abelvesa/linux:
  clk: imx95-blk-ctl: Fix REFCLK rise-fall mismatch on i.MX95
  clk: imx95-blk-ctl: Add func_out_en clock for i.MX9x PCIe
  clk: imx: imx8qxp: add missing MODULE_DEVICE_TABLE()
  clk: imx: imx8qxp-lpcg: add missing MODULE_DEVICE_TABLE()
  clk: imx: Add audio PLL debugfs for K-divider control
This commit is contained in:
Stephen Boyd 2026-08-11 22:44:52 -07:00
commit 9af2b73822
6 changed files with 146 additions and 3 deletions

View File

@ -300,6 +300,7 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct clk_hw *audio_pll_hws[2];
void __iomem *base;
int ret;
@ -610,6 +611,11 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)
imx_register_uart_clocks();
/* Add debug interface for audio PLLs */
audio_pll_hws[0] = hws[IMX8MM_AUDIO_PLL1];
audio_pll_hws[1] = hws[IMX8MM_AUDIO_PLL2];
imx_audio_pll_debug_init(audio_pll_hws, ARRAY_SIZE(audio_pll_hws));
return 0;
unregister_hws:

View File

@ -354,6 +354,7 @@ static const struct of_device_id imx8qxp_lpcg_match[] = {
{ .compatible = "fsl,imx8qxp-lpcg", NULL },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, imx8qxp_lpcg_match);
static struct platform_driver imx8qxp_lpcg_clk_driver = {
.driver = {

View File

@ -337,6 +337,7 @@ static const struct of_device_id imx8qxp_match[] = {
{ .compatible = "fsl,imx8qm-clk", &imx_clk_scu_rsrc_imx8qm, },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, imx8qxp_match);
static struct platform_driver imx8qxp_clk_driver = {
.driver = {

View File

@ -44,6 +44,8 @@ struct imx95_blk_ctl_clk_dev_data {
const char * const *parent_names;
u32 num_parents;
u32 reg;
u32 reg_init_msk;
u32 reg_init_val;
u32 bit_idx;
u32 bit_width;
u32 clk_type;
@ -286,10 +288,22 @@ static const struct imx95_blk_ctl_dev_data netcmix_dev_data = {
static const struct imx95_blk_ctl_clk_dev_data hsio_blk_ctl_clk_dev_data[] = {
[0] = {
.name = "hsio_blk_ctl_clk",
.parent_names = (const char *[]){ "func_out_en", },
.num_parents = 1,
.reg = 0,
.reg_init_msk = GENMASK(10, 7),
.reg_init_val = GENMASK(10, 7),
.bit_idx = 6,
.bit_width = 1,
.type = CLK_GATE,
.flags = CLK_SET_RATE_PARENT,
},
[1] = {
.name = "func_out_en",
.parent_names = (const char *[]){ "hsio_pll", },
.num_parents = 1,
.reg = 0,
.bit_idx = 6,
.bit_idx = 2,
.bit_width = 1,
.type = CLK_GATE,
.flags = CLK_SET_RATE_PARENT,
@ -297,7 +311,7 @@ static const struct imx95_blk_ctl_clk_dev_data hsio_blk_ctl_clk_dev_data[] = {
};
static const struct imx95_blk_ctl_dev_data hsio_blk_ctl_dev_data = {
.num_clks = 1,
.num_clks = ARRAY_SIZE(hsio_blk_ctl_clk_dev_data),
.clk_dev_data = hsio_blk_ctl_clk_dev_data,
.clk_reg_offset = 0,
};
@ -400,6 +414,9 @@ static int imx95_bc_probe(struct platform_device *pdev)
const struct imx95_blk_ctl_clk_dev_data *data = &bc->pdata->clk_dev_data[i];
void __iomem *reg = base + data->reg;
if (data->reg_init_msk)
writel((readl(reg) & ~data->reg_init_msk) | data->reg_init_val, reg);
if (data->type == CLK_MUX) {
hws[i] = clk_hw_register_mux(dev, data->name, data->parent_names,
data->num_parents, data->flags, reg,

View File

@ -8,11 +8,13 @@
#include <linux/bitfield.h>
#include <linux/bits.h>
#include <linux/clk-provider.h>
#include <linux/debugfs.h>
#include <linux/err.h>
#include <linux/export.h>
#include <linux/io.h>
#include <linux/iopoll.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/jiffies.h>
#include "clk.h"
@ -40,6 +42,8 @@ struct clk_pll14xx {
enum imx_pll14xx_type type;
const struct imx_pll14xx_rate_table *rate_table;
int rate_count;
s16 delta_k;
spinlock_t lock;
};
#define to_clk_pll14xx(_hw) container_of(_hw, struct clk_pll14xx, hw)
@ -134,6 +138,7 @@ static void imx_pll14xx_calc_settings(struct clk_pll14xx *pll, unsigned long rat
u32 pll_div_ctl0, pll_div_ctl1;
int mdiv, pdiv, sdiv, kdiv;
long fout, rate_min, rate_max, dist, best = LONG_MAX;
unsigned long flags;
const struct imx_pll14xx_rate_table *tt;
/*
@ -161,11 +166,16 @@ static void imx_pll14xx_calc_settings(struct clk_pll14xx *pll, unsigned long rat
return;
}
spin_lock_irqsave(&pll->lock, flags);
pll_div_ctl0 = readl_relaxed(pll->base + DIV_CTL0);
pll_div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
spin_unlock_irqrestore(&pll->lock, flags);
mdiv = FIELD_GET(MDIV_MASK, pll_div_ctl0);
pdiv = FIELD_GET(PDIV_MASK, pll_div_ctl0);
sdiv = FIELD_GET(SDIV_MASK, pll_div_ctl0);
pll_div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
/* Then see if we can get the desired rate by only adjusting kdiv (glitch free) */
rate_min = pll14xx_calc_rate(pll, mdiv, pdiv, sdiv, KDIV_MIN, prate);
@ -361,11 +371,14 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
{
struct clk_pll14xx *pll = to_clk_pll14xx(hw);
struct imx_pll14xx_rate_table rate;
unsigned long flags;
u32 gnrl_ctl, div_ctl0;
int ret;
imx_pll14xx_calc_settings(pll, drate, prate, &rate);
spin_lock_irqsave(&pll->lock, flags);
div_ctl0 = readl_relaxed(pll->base + DIV_CTL0);
if (!clk_pll14xx_mp_change(&rate, div_ctl0)) {
@ -377,6 +390,8 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
writel_relaxed(FIELD_PREP(KDIV_MASK, rate.kdiv),
pll->base + DIV_CTL1);
spin_unlock_irqrestore(&pll->lock, flags);
return 0;
}
@ -396,6 +411,8 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
writel_relaxed(FIELD_PREP(KDIV_MASK, rate.kdiv), pll->base + DIV_CTL1);
spin_unlock_irqrestore(&pll->lock, flags);
/*
* According to SPEC, t3 - t2 need to be greater than
* 1us and 1/FREF, respectively.
@ -508,6 +525,8 @@ struct clk_hw *imx_dev_clk_hw_pll14xx(struct device *dev, const char *name,
if (!pll)
return ERR_PTR(-ENOMEM);
spin_lock_init(&pll->lock);
init.name = name;
init.flags = pll_clk->flags;
init.parent_names = &parent_name;
@ -551,3 +570,101 @@ struct clk_hw *imx_dev_clk_hw_pll14xx(struct device *dev, const char *name,
return hw;
}
EXPORT_SYMBOL_GPL(imx_dev_clk_hw_pll14xx);
/*
* Debugfs interface for Audio PLL runtime monitoring and control
*
* This interface allows dynamic adjustment of the Audio PLL
* K-divider for precise frequency tuning, particularly useful
* for audio applications.
*
* examples for the usage of the two interfaces:
* 1): Get the current PLL setting of dividers
* cat /sys/kernel/debug/audio_pll_monitor/audio_pll1/pll_parameter
*
* 2): Adjust the K-divider by a small delta_k
* echo 1 > /sys/kernel/debug/audio_pll_monitor/audio_pll1/delta_k;
*/
#ifdef CONFIG_DEBUG_FS
static int pll_delta_k_get(void *data, u64 *val)
{
struct clk_pll14xx *pll = to_clk_pll14xx(data);
*val = pll->delta_k;
return 0;
}
static int pll_delta_k_set(void *data, u64 val)
{
struct clk_pll14xx *pll = to_clk_pll14xx(data);
unsigned long flags;
u32 div_ctl1;
s16 kdiv, delta_k;
delta_k = (s16)clamp_t(s64, val, KDIV_MIN, KDIV_MAX);
spin_lock_irqsave(&pll->lock, flags);
pll->delta_k = delta_k;
div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
kdiv = (s16)FIELD_GET(KDIV_MASK, div_ctl1);
kdiv = (s16)clamp_t(s32, (s32)kdiv + delta_k, KDIV_MIN, KDIV_MAX);
writel_relaxed(FIELD_PREP(KDIV_MASK, kdiv), pll->base + DIV_CTL1);
spin_unlock_irqrestore(&pll->lock, flags);
return 0;
}
DEFINE_DEBUGFS_ATTRIBUTE_SIGNED(delta_k_fops, pll_delta_k_get, pll_delta_k_set, "%lld\n");
static int pll_setting_show(struct seq_file *s, void *data)
{
struct clk_pll14xx *pll = to_clk_pll14xx(s->private);
unsigned long flags;
u32 div_ctl0, div_ctl1;
u32 mdiv, pdiv, sdiv, kdiv;
spin_lock_irqsave(&pll->lock, flags);
div_ctl0 = readl_relaxed(pll->base + DIV_CTL0);
div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
spin_unlock_irqrestore(&pll->lock, flags);
mdiv = FIELD_GET(MDIV_MASK, div_ctl0);
pdiv = FIELD_GET(PDIV_MASK, div_ctl0);
sdiv = FIELD_GET(SDIV_MASK, div_ctl0);
kdiv = FIELD_GET(KDIV_MASK, div_ctl1);
seq_printf(s, "Mdiv: 0x%x; Pdiv: 0x%x; Sdiv: 0x%x; Kdiv: 0x%x\n",
mdiv, pdiv, sdiv, kdiv);
return 0;
}
DEFINE_SHOW_ATTRIBUTE(pll_setting);
void imx_audio_pll_debug_init(struct clk_hw *hws[], unsigned int num_plls)
{
struct dentry *rootdir, *audio_pll_dir;
const char *pll_name;
int i;
rootdir = debugfs_create_dir("audio_pll_monitor", NULL);
for (i = 0; i < num_plls; i++) {
if (!IS_ERR_OR_NULL(hws[i])) {
pll_name = clk_hw_get_name(hws[i]);
audio_pll_dir = debugfs_create_dir(pll_name, rootdir);
debugfs_create_file_unsafe("delta_k", 0600, audio_pll_dir,
hws[i], &delta_k_fops);
debugfs_create_file("pll_parameter", 0444, audio_pll_dir,
hws[i], &pll_setting_fops);
}
}
}
#else /* !CONFIG_DEBUG_FS */
void imx_audio_pll_debug_init(struct clk_hw *hws[], unsigned int num_plls)
{
}
#endif /* CONFIG_DEBUG_FS */
EXPORT_SYMBOL_GPL(imx_audio_pll_debug_init);

View File

@ -487,4 +487,5 @@ struct clk_hw *imx_clk_gpr_mux(const char *name, const char *compatible,
u32 reg, const char **parent_names,
u8 num_parents, const u32 *mux_table, u32 mask);
void imx_audio_pll_debug_init(struct clk_hw *hws[], unsigned int num_plls);
#endif