github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ASoC: stm: Drop redundant error message

Browse Source 
bui duc phuc <phucduc.bui@gmail.com> says:

This series removes redundant error messages across multiple STM32 ASoC
drivers. Since core functions already log failures internally, dropping
these explicit dev_err() blocks prevents duplicate log messages and
cleans up the code.

Compile-tested only.

Link: https://patch.msgid.link/20260720074044.87528-1-phucduc.bui@gmail.com
This commit is contained in:
Mark Brown 2026-07-30 00:19:53 +01:00
commit 57e65e0b22
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
4 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/stm/stm32_adfsdm.c
View File

@ -360,11 +360,8 @@ static int stm32_adfsdm_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_component(&pdev->dev,
&stm32_adfsdm_soc_platform,
NULL, 0);
if (ret < 0) {
dev_err(&pdev->dev, "%s: Failed to register PCM platform\n",
__func__);
if (ret < 0)
return ret;
}
pm_runtime_enable(&pdev->dev);

6
sound/soc/stm/stm32_i2s.c
View File

@ -1238,10 +1238,8 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev,
ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0,
dev_name(&pdev->dev), i2s);
if (ret) {
dev_err(&pdev->dev, "irq request returned %d\n", ret);
if (ret)
return ret;
}
/* Reset */
rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
@ -1295,7 +1293,7 @@ static int stm32_i2s_probe(struct platform_device *pdev)
ret = snd_dmaengine_pcm_register(&pdev->dev, &stm32_i2s_pcm_config, 0);
if (ret)
return dev_err_probe(&pdev->dev, ret, "PCM DMA register error\n");
return ret;
ret = snd_soc_register_component(&pdev->dev, &stm32_i2s_component,
i2s->dai_drv, 1);

8
sound/soc/stm/stm32_sai_sub.c
View File

@ -1696,19 +1696,15 @@ static int stm32_sai_sub_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, sai->pdata->irq, stm32_sai_isr,
IRQF_SHARED, dev_name(&pdev->dev), sai);
if (ret) {
dev_err(&pdev->dev, "IRQ request returned %d\n", ret);
if (ret)
goto err_unprepare_pclk;
}
if (STM_SAI_PROTOCOL_IS_SPDIF(sai))
conf = &stm32_sai_pcm_config_spdif;
ret = snd_dmaengine_pcm_register(&pdev->dev, conf, 0);
if (ret) {
ret = dev_err_probe(&pdev->dev, ret, "Could not register pcm dma\n");
if (ret)
goto err_unprepare_pclk;
}
ret = snd_soc_register_component(&pdev->dev, &stm32_component,
&sai->cpu_dai_drv, 1);

6
sound/soc/stm/stm32_spdifrx.c
View File

@ -970,10 +970,8 @@ static int stm32_spdifrx_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, spdifrx->irq, stm32_spdifrx_isr, 0,
dev_name(&pdev->dev), spdifrx);
if (ret) {
dev_err(&pdev->dev, "IRQ request returned %d\n", ret);
if (ret)
return ret;
}
rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
if (IS_ERR(rst))
@ -987,7 +985,7 @@ static int stm32_spdifrx_probe(struct platform_device *pdev)
pcm_config = &stm32_spdifrx_pcm_config;
ret = snd_dmaengine_pcm_register(&pdev->dev, pcm_config, 0);
if (ret)
return dev_err_probe(&pdev->dev, ret, "PCM DMA register error\n");
return ret;
ret = snd_soc_register_component(&pdev->dev,
&stm32_spdifrx_component,