mirror of
https://github.com/Crosstalk-Solutions/project-nomad.git
synced 2026-10-17 05:14:19 +02:00
bf7e4b3b48
#1165 taught the benchmark path to reject an unresolved PCI id as a GPU model, but isUnresolvedGpuModel lived inside benchmark_service.ts and the Settings > System display path never learned the same thing. It still shows whatever lspci handed back. The two symptoms of a stale pci.ids database are independent, which is why the existing guard misses this. system_service already re-probes when a discrete-GPU controller reports an implausible BAR0 reading as VRAM, and that happens to fix the name as a side effect. But lspci can return a perfectly plausible VRAM figure alongside a name it could not resolve, and then nothing fires. Confirmed live on an AMD box. The Radeon 780M reports: model: "Device 1900", vram: 512 512 MiB clears the 256 MiB bogus-VRAM threshold, so no probe runs and the System page renders "Device 1900". The same box's Ollama startup log carries description="AMD Radeon 780M Graphics", so the probe the guard declined to run had the real name available the whole time. NVIDIA hides this because its path tends to be reached for other reasons; AMD has no equivalent. Adds an unresolved-name trigger alongside the VRAM one, and moves isUnresolvedGpuModel to app/utils/gpu_model.ts so the submission path and the display path share one definition instead of diverging again. Tests cover both placeholder shapes and, more importantly, a set of real product names that must never be rejected. Stacked on #1277, so the shared helper carries the WSL placeholders too. Closes #1196 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| amd_hsa_override.spec.ts | ||
| app_auto_update.spec.ts | ||
| cloud_metadata_url.spec.ts | ||
| content_auto_update_backoff.spec.ts | ||
| content_auto_update.spec.ts | ||
| content_reindex_decision.spec.ts | ||
| context_budget.spec.ts | ||
| context_window.spec.ts | ||
| curated_resource_schema.spec.ts | ||
| custom_app_guard.spec.ts | ||
| drug_ingest_status.spec.ts | ||
| drug_interactions.spec.ts | ||
| drug_labels.spec.ts | ||
| eval_generation_metrics.spec.ts | ||
| eval_golden_set.spec.ts | ||
| eval_report.spec.ts | ||
| eval_retrieval_metrics.spec.ts | ||
| eval_source_guard.spec.ts | ||
| global_map_banner.spec.ts | ||
| gpu_model.spec.ts | ||
| kb_file_grouping.spec.ts | ||
| kb_guardrail.spec.ts | ||
| kb_ingest_decision.spec.ts | ||
| kb_job_health.spec.ts | ||
| kb_ratio_lookup.spec.ts | ||
| kb_warning_decision.spec.ts | ||
| platform_metadata.spec.ts | ||
| private_url.spec.ts | ||
| queue_stall_options.spec.ts | ||
| rag_pipeline_prompt.spec.ts | ||
| rag_relevance.spec.ts | ||
| rag_retrieval_toggle.spec.ts | ||
| structured_output.spec.ts | ||
| superseded_resource.spec.ts | ||
| tasks_model.spec.ts | ||
| think_stream.spec.ts | ||
| token_estimate.spec.ts | ||
| zim_batch_decision.spec.ts | ||
| zim_download_resolution.spec.ts | ||
| zim_filename.spec.ts | ||
| zim_html.spec.ts | ||