mirror of
https://github.com/Crosstalk-Solutions/project-nomad.git
synced 2026-10-17 13:19:18 +02:00
Every Docker pull went through `followProgress(pullStream, resolve)`, passing the Promise's resolve as dockerode's onFinished(err, output) callback — so the error argument was ignored and a failed pull (dropped/metered connection, bad manifest, registry error, disk full mid-pull) resolved as if it had succeeded. The code then tried to create/start a container from a missing or partial image, surfacing a confusing downstream error rather than the real cause. (#790) Add a DockerService.pullImage() helper that rejects when followProgress reports an error, and route all five pull sites through it: - service install - AMD ROCm image pull - service update - force-reinstall / recreate (forcePull) - sysbench benchmark image pull Closes #790 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| controllers | ||
| exceptions | ||
| jobs | ||
| middleware | ||
| models | ||
| services | ||
| utils | ||
| validators | ||