mirror of
https://github.com/Crosstalk-Solutions/project-nomad.git
synced 2026-06-03 18:16:49 +02:00
019a5a4927
Closes #855. PR #804's AMD branch in `updateContainer()` overrode `newImage` to `ollama/ollama:rocm` and then persisted that literal string to `service.container_image` (line 1273). Two downstream consequences for every AMD user who clicked Update on AI Assistant: 1. Apps page (`apps.tsx`) extracts the displayed version from `container_image` and rendered the literal string "rocm". 2. `ContainerRegistryService.getAvailableUpdates()` parsed `currentTag = "rocm"`, which isn't semver, so `parseMajorVersion` returned NaN, the filter didn't reject newer tags by major-version, and `isNewerVersion` treated any future tag as newer. Result: the same update reappeared on every check, forever. Fix: separate "what we run" from "what we persist". `runtimeImage` holds the tag passed to `docker.pull()` and `createContainer()` (still `:rocm` for AMD), while `newImage` keeps the semver tag and is the value written to the DB. Surgical: 3 references renamed plus 1 declaration added. The install path (`_createContainer`) already had the right shape (runtime-only override, no DB write of the override), so this PR only touches `updateContainer`. Test plan: - `npm run typecheck` passes locally. - Manual repro on NOMAD2 (AMD HX 370 / 890M, rc.2): before fix, DB shows `container_image = ollama/ollama:rocm` after triggering an Ollama update via Settings > Apps; Apps page shows version "rocm"; `/api/system/services/check-updates` immediately re-reports the same update available. After fix, DB shows `container_image = ollama/ollama:<targetVersion>`; Apps page shows the semver; check- updates does not re-report the same update. - nomad_ollama container itself still runs the `:rocm` image (verified via `docker inspect`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| app | ||
| bin | ||
| commands | ||
| config | ||
| constants | ||
| database | ||
| docs | ||
| inertia | ||
| providers | ||
| public | ||
| resources | ||
| start | ||
| tests | ||
| types | ||
| util | ||
| views | ||
| .editorconfig | ||
| .env.example | ||
| ace.js | ||
| adonisrc.ts | ||
| eslint.config.js | ||
| package-lock.json | ||
| package.json | ||
| tailwind.config.ts | ||
| tsconfig.json | ||
| vite.config.ts | ||