mirror of
https://github.com/Crosstalk-Solutions/project-nomad.git
synced 2026-10-17 05:14:19 +02:00
* feat(translate): offline translation for the Information Library Implements #1272. Ships as a Supply Depot app so users who do not need translation never see it. A path-preserving reverse proxy in front of kiwix-serve. /viewer, /skin/*, /search, /random and /catalog/* are forwarded byte for byte; only text/html under /content/ is rewritten. Preserving the path is the whole design: viewer.js keeps the content iframe in sync with location.hash by comparing contentWindow.location.pathname, so moving the path starts the ping-pong its own comment warns about and forces us to patch Kiwix's JavaScript on every Kiwix bump. Because the path never moves, no Kiwix JS is modified, and Kiwix's header, search, library and random keep working because they are Kiwix. Language is a cookie, so links inside the ZIM need no rewriting either. Bergamot rather than the AI Assistant: measured on the same box and the same passage, 12,818 words/s on CPU against llama3.1:8b at 8 words/s on an RTX 5060. It is also more careful with names, where the LLM translated the product name and a smaller model hallucinated a clause. No GPU, so it works on CPU-only boxes where the LLM path is unusable. Models come from Firefox Remote Settings, the endpoint Firefox itself uses, not the mozilla/firefox-translations-models repo, which was archived on 2026-08-21. MPL-2.0, about 37 MB per direction. Failure handling is deliberate throughout: a failed model fetch is non-fatal, a translation error returns the original article with a comment rather than an error page, and a box with no models still starts and still forwards the library. Translation being unavailable must never make the Information Library unreachable. amd64 only, and pinned as such in the build workflow. Bergamot's intgemm backend is x86 specific and there is no aarch64 wheel, so a multi-arch build would produce an ARM image that pulls cleanly and dies at start. Also adds .gitattributes pinning *.sh to LF. The repo stores LF but Windows checks out CRLF, and a CRLF after a shebang makes the interpreter unresolvable inside the image. CI builds on Linux so this never bit, but it breaks a local image build and would have bitten the existing sidecar script too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F8Mgg1vd2eKSs8StZiuyMV * fix(translate): vary the cache on the language cookie Found by clicking the language buttons in a browser rather than trusting curl. Kiwix sends ETag and Cache-Control: max-age=3600, and the proxy forwarded both unchanged on a response whose content now varies by cookie. The browser cached the English article for an hour and served it straight back when the reader picked a language, so the feature looked like it simply did not work. A shared cache would have been worse, serving one reader's language to another. Translatable responses now send Vary: Cookie, and their ETag is namespaced by language so revalidation still works per language rather than being turned off. Forwarded paths are untouched, so /viewer, /skin/* and /catalog/* stay byte for byte identical to Kiwix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F8Mgg1vd2eKSs8StZiuyMV * fix(translate): move off port 8480, which Vaultwarden already uses Caught by seeing the two cards side by side in Supply Depot with the same port. My port survey grepped ui_location for a bare number, and Vaultwarden's is 'https:8480' because it needs an https Open link, so it did not match and 8480 looked free. Moved to 8460, which fits the existing spacing between Meshtastic Web on 8450 and Homebox on 8470. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F8Mgg1vd2eKSs8StZiuyMV * fix(translate): pin the base image to python 3.10 The build fails outright on 3.12: bergamot publishes no wheel for it and pip resolves no further than 0.1.2. The spike used 3.10 for this reason and I had modernised it without checking. Caught by building the image rather than reading it. Moving off this pin means moving off the 2022 PyPI wheel to a build from mozilla/translations, which is the follow-up already noted in the Dockerfile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F8Mgg1vd2eKSs8StZiuyMV * fix(translate): translate text that lives in a bare div Sotoki-generated StackExchange ZIMs put every question excerpt in a <div class="...excerpt">, so on a questions list the titles translated and the descriptions underneath them did not. Reported against the ham radio ZIM. div could not simply be added to BLOCK_TAGS: the outermost-block rule would claim a top-level layout wrapper and send the whole page as one job. It is now claimed speculatively and abandoned the moment anything block-level opens inside it, so a wrapper yields to the blocks it contains and only a genuine text leaf is translated. Also moves the test harness's reporting block back to the end of the file. New checks had been appended after it, so they executed but their failures were never reported: verified that removing div from the set now fails 3 checks, where before it reported success. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F8Mgg1vd2eKSs8StZiuyMV * fix(translate): decode numeric character references before translating Bergamot's HTML mode decodes named entities (`&` arrives as "&") but not numeric ones. It treats `'` as literal text and escapes the ampersand on the way out, so "If I'm in the wilderness" came back as "Si I&#x27;m dans la nature" and rendered the escape sequence visibly to the user. Confirmed by round-tripping fragments through the model directly. Numeric refs are now decoded before the round trip. `&`, `<` and `>` are deliberately left encoded: decoding those would inject real markup into the fragment and fail the balance check that gates HTML mode, dropping the block to plain text and losing its inline links. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F8Mgg1vd2eKSs8StZiuyMV --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
223 lines
7.9 KiB
Python
223 lines
7.9 KiB
Python
#!/usr/bin/env python3
|
|
"""Tests for the block planner.
|
|
|
|
Pure functions only, no Bergamot and no network, so this runs anywhere:
|
|
|
|
python3 install/nomad-translate/test_blocks.py
|
|
|
|
Each case here is a failure the prototype actually hit. HTML mode raises
|
|
"Not all tags were closed" rather than degrading, so anything that gets the
|
|
balance check wrong takes the whole article down.
|
|
"""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent))
|
|
|
|
import blocks # noqa: E402
|
|
|
|
failures: list[str] = []
|
|
|
|
|
|
def check(name: str, got, want):
|
|
if got != want:
|
|
failures.append(f"{name}\n expected: {want!r}\n got: {got!r}")
|
|
|
|
|
|
def check_true(name: str, got):
|
|
check(name, bool(got), True)
|
|
|
|
|
|
def check_false(name: str, got):
|
|
check(name, bool(got), False)
|
|
|
|
|
|
# --- balance check -----------------------------------------------------------
|
|
|
|
check_true("balanced: plain text", blocks.balanced("just words"))
|
|
check_true("balanced: matched inline tags", blocks.balanced('<a href="X">water</a>'))
|
|
check_true("balanced: nested inline tags", blocks.balanced("<b><i>x</i></b>"))
|
|
check_true("balanced: void tag needs no close", blocks.balanced("a<br>b"))
|
|
check_true("balanced: self-closing", blocks.balanced('<img src="x"/>'))
|
|
check_false("balanced: unclosed tag", blocks.balanced("<b>x"))
|
|
check_false("balanced: stray close", blocks.balanced("x</b>"))
|
|
check_false("balanced: crossed tags", blocks.balanced("<b><i>x</b></i>"))
|
|
|
|
# --- block finding -----------------------------------------------------------
|
|
|
|
# The nesting case regex cannot handle: a non-greedy <li>...</li> stops at the
|
|
# INNER list's closing tag, silently truncating the block.
|
|
NESTED = "<ul><li>outer <ul><li>inner</li></ul> tail</li></ul>"
|
|
jobs, kinds, spans = blocks.plan(NESTED)
|
|
check("nested li: one outermost block claimed", len(jobs), 1)
|
|
check_true("nested li: keeps the whole outer li", "tail" in jobs[0])
|
|
check_true("nested li: contains the inner list", "inner" in jobs[0])
|
|
|
|
# Opaque elements must never be descended into.
|
|
check("script is opaque", blocks.plan("<script><p>var x</p></script>")[0], [])
|
|
check("style is opaque", blocks.plan("<style><p>a{}</p></style>")[0], [])
|
|
check("pre is opaque", blocks.plan("<pre><p>code</p></pre>")[0], [])
|
|
# Tables are excluded wholesale to dodge the nesting problem, which is why
|
|
# infobox rows stay in the source language.
|
|
check("table is opaque", blocks.plan("<table><tr><td>cell text</td></tr></table>")[0], [])
|
|
|
|
# Blocks with no real text are not worth a round trip.
|
|
check("digits only are skipped", blocks.plan("<p>12345</p>")[0], [])
|
|
check("punctuation only is skipped", blocks.plan("<p>--- .</p>")[0], [])
|
|
check("single letter is skipped", blocks.plan("<p>a</p>")[0], [])
|
|
check("two letters count as text", blocks.plan("<p>ok</p>")[0], ["ok"])
|
|
|
|
# Crossed inline markup inside a block that DOES close: the span is found, the
|
|
# balance check rejects it, and it falls back to plain text. Losing the inline
|
|
# tags is the price of not having Bergamot raise on the whole article.
|
|
jobs, kinds, _ = blocks.plan("<p><b><i>hello</b></i></p>")
|
|
check("crossed inline markup falls back to text", kinds, ["text"])
|
|
check("fallback strips the tags", jobs, ["hello"])
|
|
|
|
# A block whose own closing tag is unreachable because an inner tag was never
|
|
# closed is DROPPED, not translated. handle_endtag sees the wrong depth, so no
|
|
# span is ever claimed and the balance check is never consulted.
|
|
#
|
|
# This is safe (the reader gets the original) but silent: that paragraph simply
|
|
# stays in the source language with nothing to indicate why. Worth knowing when
|
|
# a page comes back partly translated.
|
|
check("block with an unclosed inner tag is dropped", blocks.plan("<p>see <b>this</p>")[0], [])
|
|
|
|
# Balanced markup goes through HTML mode so the aligner can place inline tags.
|
|
jobs, kinds, _ = blocks.plan('<p>drink <a href="Water">water</a></p>')
|
|
check("balanced block uses html mode", kinds, ["html"])
|
|
check_true("html mode keeps the anchor", "<a href=" in jobs[0])
|
|
|
|
# --- splice ------------------------------------------------------------------
|
|
|
|
body = "<p>one</p><p>two</p>"
|
|
jobs, kinds, spans = blocks.plan(body)
|
|
check("two paragraphs found", jobs, ["one", "two"])
|
|
# Back-to-front application is what keeps the earlier offsets valid.
|
|
check(
|
|
"splice replaces both, longer than the source",
|
|
blocks.splice(body, spans, ["un ONE", "deux TWO"]),
|
|
"<p>un ONE</p><p>deux TWO</p>",
|
|
)
|
|
|
|
# --- plain -------------------------------------------------------------------
|
|
|
|
check("plain strips tags", blocks.plain("<b>hi</b> there"), "hi there")
|
|
check("plain decodes entities", blocks.plain("café"), "café")
|
|
|
|
# --- malformed input ---------------------------------------------------------
|
|
|
|
# A page that will not parse must yield no work rather than raising: the reader
|
|
# gets the untranslated article instead of an error.
|
|
check("garbage yields no blocks", blocks.plan("<<<>>><p")[0], [])
|
|
check("empty document yields no blocks", blocks.plan("")[0], [])
|
|
|
|
|
|
|
|
|
|
# --- leaf-div claiming -------------------------------------------------------
|
|
#
|
|
# Real prose lives in a bare <div> often enough that excluding them lost whole
|
|
# pages: sotoki StackExchange ZIMs put every question excerpt in one, so the
|
|
# titles translated while the descriptions under them did not.
|
|
|
|
check(
|
|
"leaf div is claimed",
|
|
blocks.plan('<div class="excerpt">Why do people still use Morse code?</div>')[0],
|
|
["Why do people still use Morse code?"],
|
|
)
|
|
|
|
# A wrapper must yield to the blocks inside it rather than swallowing the page.
|
|
check(
|
|
"layout div yields to its children",
|
|
blocks.plan('<div class="wrap"><p>First para.</p><p>Second para.</p></div>')[0],
|
|
["First para.", "Second para."],
|
|
)
|
|
|
|
check(
|
|
"nested divs claim the innermost text",
|
|
blocks.plan('<div><div><div class="excerpt">Inner text.</div></div></div>')[0],
|
|
["Inner text."],
|
|
)
|
|
|
|
# Inline tags stay inside the job so the aligner can re-place them.
|
|
check(
|
|
"leaf div keeps inline markup",
|
|
blocks.plan('<div>See <a href="X">the antenna</a> guide.</div>')[0],
|
|
['See <a href="X">the antenna</a> guide.'],
|
|
)
|
|
|
|
check(
|
|
"div inside an opaque table is still skipped",
|
|
blocks.plan("<table><tr><td><div>Cell text.</div></td></tr></table>")[0],
|
|
[],
|
|
)
|
|
|
|
check(
|
|
"textless div is dropped",
|
|
blocks.plan('<div class="spacer"> </div><div>42</div>')[0],
|
|
[],
|
|
)
|
|
|
|
|
|
|
|
|
|
# --- numeric character references --------------------------------------------
|
|
#
|
|
# Bergamot decodes named entities but not numeric ones: it treats `'` as
|
|
# literal text and escapes the ampersand on output, so an apostrophe came back
|
|
# as the visible string `'`. Reported against the ham radio ZIM.
|
|
|
|
check(
|
|
"hex charref is decoded before translation",
|
|
blocks.plan("<p>If I'm here</p>")[0],
|
|
["If I'm here"],
|
|
)
|
|
|
|
check(
|
|
"decimal charref is decoded before translation",
|
|
blocks.plan("<p>If I'm here</p>")[0],
|
|
["If I'm here"],
|
|
)
|
|
|
|
check(
|
|
"non-ascii charref is decoded",
|
|
blocks.plan("<p>café here</p>")[0],
|
|
["café here"],
|
|
)
|
|
|
|
# Decoding these would inject real markup and break the balance check that gates
|
|
# HTML mode, dropping the block to plain text and losing its links.
|
|
check(
|
|
"markup-significant charrefs stay encoded",
|
|
blocks.plan("<p>Compare <dipole> designs & feeds</p>")[0],
|
|
["Compare <dipole> designs & feeds"],
|
|
)
|
|
|
|
check(
|
|
"named entities are left alone",
|
|
blocks.plan("<p>Tom & Jerry <tag></p>")[0],
|
|
["Tom & Jerry <tag>"],
|
|
)
|
|
|
|
check(
|
|
"malformed charrefs are left untouched",
|
|
blocks.decode_numeric_refs("bare &# and &#xZZ; and � here"),
|
|
"bare &# and &#xZZ; and � here",
|
|
)
|
|
|
|
check(
|
|
"helper decodes hex and decimal, leaves markup chars",
|
|
blocks.decode_numeric_refs("' ' é < &"),
|
|
"' ' é < &",
|
|
)
|
|
|
|
if failures:
|
|
print(f"FAIL: {len(failures)} of the checks above did not hold\n")
|
|
for failure in failures:
|
|
print(f" {failure}\n")
|
|
sys.exit(1)
|
|
|
|
print("ok: all block planner checks passed")
|