github-mirror/project-nomad
1
0
Fork 0
mirror of https://github.com/Crosstalk-Solutions/project-nomad.git synced 2026-04-03 23:36:17 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(security): sanitize verbose errors in benchmark controller

Browse Source
This commit is contained in:
LuisMIguelFurlanettoSousa 2026-03-25 21:30:35 -03:00
parent fa1036bd31
commit a85a38e922
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
admin/app/controllers/benchmark_controller.ts
View File

@ -5,6 +5,7 @@ import { runBenchmarkValidator, submitBenchmarkValidator } from '#validators/ben
import { RunBenchmarkJob } from '#jobs/run_benchmark_job' import { RunBenchmarkJob } from '#jobs/run_benchmark_job'
import type { BenchmarkType } from '../../types/benchmark.js' import type { BenchmarkType } from '../../types/benchmark.js'
import { randomUUID } from 'node:crypto' import { randomUUID } from 'node:crypto'
import logger from '@adonisjs/core/services/logger'
@inject() @inject()
export default class BenchmarkController { export default class BenchmarkController {
@ -52,9 +53,10 @@ export default class BenchmarkController {
result, result,
}) })
} catch (error) { } catch (error) {
logger.error({ err: error }, '[BenchmarkController] Benchmark run failed')
return response.status(500).send({ return response.status(500).send({
success: false, success: false,
error: error.message, error: 'An internal error occurred while running the benchmark.',
}) })
} }
} }
@ -181,9 +183,10 @@ export default class BenchmarkController {
} catch (error) { } catch (error) {
// Pass through the status code from the service if available, otherwise default to 400 // Pass through the status code from the service if available, otherwise default to 400
const statusCode = (error as any).statusCode || 400 const statusCode = (error as any).statusCode || 400
logger.error({ err: error }, '[BenchmarkController] Benchmark submit failed')
return response.status(statusCode).send({ return response.status(statusCode).send({
success: false, success: false,
error: error.message, error: 'Failed to submit benchmark results.',
}) })
} }
} }