github-mirror/project-nomad
1
0
Fork 0
mirror of https://github.com/Crosstalk-Solutions/project-nomad.git synced 2026-04-09 02:06:16 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(security): sanitize verbose errors in chats controller (6 instances)

Browse Source
This commit is contained in:
LuisMIguelFurlanettoSousa 2026-03-25 21:31:30 -03:00
parent 8ca8c6c6b8
commit a107dbe429
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
admin/app/controllers/chats_controller.ts
View File

@ -5,6 +5,7 @@ import { createSessionSchema, updateSessionSchema, addMessageSchema } from '#val
import KVStore from '#models/kv_store' import KVStore from '#models/kv_store'
import { SystemService } from '#services/system_service' import { SystemService } from '#services/system_service'
import { SERVICE_NAMES } from '../../constants/service_names.js' import { SERVICE_NAMES } from '../../constants/service_names.js'
import logger from '@adonisjs/core/services/logger'
@inject() @inject()
export default class ChatsController { export default class ChatsController {
@ -45,8 +46,9 @@ export default class ChatsController {
const session = await this.chatService.createSession(data.title, data.model) const session = await this.chatService.createSession(data.title, data.model)
return response.status(201).json(session) return response.status(201).json(session)
} catch (error) { } catch (error) {
logger.error({ err: error }, '[ChatsController] Failed to create session')
return response.status(500).json({ return response.status(500).json({
error: error instanceof Error ? error.message : 'Failed to create session', error: 'Failed to create session',
}) })
} }
} }
@ -56,8 +58,9 @@ export default class ChatsController {
const suggestions = await this.chatService.getChatSuggestions() const suggestions = await this.chatService.getChatSuggestions()
return response.status(200).json({ suggestions }) return response.status(200).json({ suggestions })
} catch (error) { } catch (error) {
logger.error({ err: error }, '[ChatsController] Failed to get suggestions')
return response.status(500).json({ return response.status(500).json({
error: error instanceof Error ? error.message : 'Failed to get suggestions', error: 'Failed to get suggestions',
}) })
} }
} }
@ -69,8 +72,9 @@ export default class ChatsController {
const session = await this.chatService.updateSession(sessionId, data) const session = await this.chatService.updateSession(sessionId, data)
return session return session
} catch (error) { } catch (error) {
logger.error({ err: error }, '[ChatsController] Failed to update session')
return response.status(500).json({ return response.status(500).json({
error: error instanceof Error ? error.message : 'Failed to update session', error: 'Failed to update session',
}) })
} }
} }
@ -81,8 +85,9 @@ export default class ChatsController {
await this.chatService.deleteSession(sessionId) await this.chatService.deleteSession(sessionId)
return response.status(204) return response.status(204)
} catch (error) { } catch (error) {
logger.error({ err: error }, '[ChatsController] Failed to delete session')
return response.status(500).json({ return response.status(500).json({
error: error instanceof Error ? error.message : 'Failed to delete session', error: 'Failed to delete session',
}) })
} }
} }
@ -94,8 +99,9 @@ export default class ChatsController {
const message = await this.chatService.addMessage(sessionId, data.role, data.content) const message = await this.chatService.addMessage(sessionId, data.role, data.content)
return response.status(201).json(message) return response.status(201).json(message)
} catch (error) { } catch (error) {
logger.error({ err: error }, '[ChatsController] Failed to add message')
return response.status(500).json({ return response.status(500).json({
error: error instanceof Error ? error.message : 'Failed to add message', error: 'Failed to add message',
}) })
} }
} }
@ -105,8 +111,9 @@ export default class ChatsController {
const result = await this.chatService.deleteAllSessions() const result = await this.chatService.deleteAllSessions()
return response.status(200).json(result) return response.status(200).json(result)
} catch (error) { } catch (error) {
logger.error({ err: error }, '[ChatsController] Failed to delete all sessions')
return response.status(500).json({ return response.status(500).json({
error: error instanceof Error ? error.message : 'Failed to delete all sessions', error: 'Failed to delete all sessions',
}) })
} }
} }