github-mirror/project-nomad
1
0
Fork 0
mirror of https://github.com/Crosstalk-Solutions/project-nomad.git synced 2026-04-03 23:36:17 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(security): sanitize verbose errors in docker service (6 instances)

Browse Source
This commit is contained in:
LuisMIguelFurlanettoSousa 2026-03-25 21:32:15 -03:00
parent a107dbe429
commit 07348c293e
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
admin/app/services/docker_service.ts
View File

@ -92,10 +92,10 @@ export class DockerService {
message: `Invalid action: ${action}. Use 'start', 'stop', or 'restart'.`, message: `Invalid action: ${action}. Use 'start', 'stop', or 'restart'.`,
} }
} catch (error) { } catch (error) {
logger.error(`Error starting service ${serviceName}: ${error.message}`) logger.error({ err: error }, `[DockerService] Error controlling service ${serviceName}`)
return { return {
success: false, success: false,
message: `Failed to start service ${serviceName}: ${error.message}`, message: `Failed to ${action} service ${serviceName}. Check server logs for details.`,
} }
} }
} }
@ -308,8 +308,8 @@ export class DockerService {
) )
} }
} catch (error) { } catch (error) {
logger.warn(`Error during container cleanup: ${error.message}`) logger.warn({ err: error }, `[DockerService] Error during container cleanup for ${serviceName}`)
this._broadcast(serviceName, 'cleanup-warning', `Warning during cleanup: ${error.message}`) this._broadcast(serviceName, 'cleanup-warning', 'Warning during container cleanup. Check server logs for details.')
} }
// Step 3: Clear volumes/data if needed // Step 3: Clear volumes/data if needed
@ -335,11 +335,11 @@ export class DockerService {
this._broadcast(serviceName, 'no-volumes', `No volumes found to clear`) this._broadcast(serviceName, 'no-volumes', `No volumes found to clear`)
} }
} catch (error) { } catch (error) {
logger.warn(`Error during volume cleanup: ${error.message}`) logger.warn({ err: error }, `[DockerService] Error during volume cleanup for ${serviceName}`)
this._broadcast( this._broadcast(
serviceName, serviceName,
'volume-cleanup-warning', 'volume-cleanup-warning',
`Warning during volume cleanup: ${error.message}` 'Warning during volume cleanup. Check server logs for details.'
) )
} }
@ -363,11 +363,11 @@ export class DockerService {
message: `Service ${serviceName} force reinstall initiated successfully. You can receive updates via server-sent events.`, message: `Service ${serviceName} force reinstall initiated successfully. You can receive updates via server-sent events.`,
} }
} catch (error) { } catch (error) {
logger.error(`Force reinstall failed for ${serviceName}: ${error.message}`) logger.error({ err: error }, `[DockerService] Force reinstall failed for ${serviceName}`)
await this._cleanupFailedInstallation(serviceName) await this._cleanupFailedInstallation(serviceName)
return { return {
success: false, success: false,
message: `Failed to force reinstall service ${serviceName}: ${error.message}`, message: `Failed to force reinstall service ${serviceName}. Check server logs for details.`,
} }
} }
} }
@ -601,10 +601,10 @@ export class DockerService {
return { success: true, message: `Service ${serviceName} container removed successfully` } return { success: true, message: `Service ${serviceName} container removed successfully` }
} catch (error) { } catch (error) {
logger.error(`Error removing service container: ${error.message}`) logger.error({ err: error }, `[DockerService] Error removing service container ${serviceName}`)
return { return {
success: false, success: false,
message: `Failed to remove service ${serviceName} container: ${error.message}`, message: `Failed to remove service ${serviceName} container. Check server logs for details.`,
} }
} }
} }
@ -1028,10 +1028,10 @@ export class DockerService {
this._broadcast( this._broadcast(
serviceName, serviceName,
'update-rollback', 'update-rollback',
`Update failed: ${error.message}` 'Update failed. Check server logs for details.'
) )
logger.error(`[DockerService] Update failed for ${serviceName}: ${error.message}`) logger.error({ err: error }, `[DockerService] Update failed for ${serviceName}`)
return { success: false, message: `Update failed: ${error.message}` } return { success: false, message: 'Update failed. Check server logs for details.' }
} }
} }