From b126237a98f43bb009fee401f2d5d512aaa5e1fe Mon Sep 17 00:00:00 2001 From: swithek <52840391+swithek@users.noreply.github.com> Date: Sun, 6 Sep 2026 11:45:20 +0200 Subject: [PATCH] update name editor hook menu icon on mobile --- .../components/editor/NameEditor.nuxt.test.ts | 13 ++++++++++++ web/app/components/editor/NameEditor.vue | 21 +++++++++++++++---- 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/web/app/components/editor/NameEditor.nuxt.test.ts b/web/app/components/editor/NameEditor.nuxt.test.ts index 8534b361..129aaee1 100644 --- a/web/app/components/editor/NameEditor.nuxt.test.ts +++ b/web/app/components/editor/NameEditor.nuxt.test.ts @@ -24,6 +24,7 @@ import { findButtonByText, menuItem, mountUnderTooltipProvider, + renderedIconNames, seedAuthOrganization, seedAuthSession, settleMutations, @@ -387,6 +388,18 @@ describe("", { concurrent: false }, () => { expect(highlightPanels()).toHaveLength(0) }) + it("carries both the wide and the narrow hook handle glyph", async ({ + expect, + }) => { + // which of the two shows is a breakpoint the stylesheet decides, so + // both are in the markup + const wrapper = await mountEditor() + + expect(renderedIconNames(wrapper)).toEqual( + expect.arrayContaining(["mingcute:leaf-line", "mingcute:dots-line"]), + ) + }) + it("takes the hook handle away while a diff is on", async ({ expect }) => { const wrapper = await mountEditor({ target: makeBranch() }) diff --git a/web/app/components/editor/NameEditor.vue b/web/app/components/editor/NameEditor.vue index 9eab62df..da4b8b9d 100644 --- a/web/app/components/editor/NameEditor.vue +++ b/web/app/components/editor/NameEditor.vue @@ -397,7 +397,7 @@ async function executeReviewableAction() { :data-menu-open="hookMenuOpen ? '' : undefined" :class=" cn( - 'group/hook-handle absolute top-0.5 right-full flex h-7 items-center pr-1 lg:pr-1.5', + 'group/hook-handle absolute top-0.5 right-full flex h-7 items-center pr-1.5', 'pointer-events-none opacity-0 transition-opacity duration-100', 'group-hover/name-row:pointer-events-auto group-hover/name-row:opacity-100', 'data-menu-open:pointer-events-auto data-menu-open:opacity-100', @@ -407,17 +407,30 @@ async function executeReviewableAction() { @mouseleave="hoveringHookHandle = false" >
+ +
+ +