n8n/packages/nodes-base/nodes/MongoDb/GenericFunctions.test.ts
Juuso Tapaninen 439d260181
Some checks failed
CI: Master (Build, Test, Lint) / Build for Github Cache (push) Waiting to run
CI: Master (Build, Test, Lint) / Unit tests (22.22.3) (push) Waiting to run
CI: Master (Build, Test, Lint) / Unit tests (24.15.0) (push) Waiting to run
CI: Master (Build, Test, Lint) / Lint (push) Waiting to run
CI: Master (Build, Test, Lint) / Performance (push) Waiting to run
CI: Master (Build, Test, Lint) / Notify Slack on failure (push) Blocked by required conditions
Util: Sync API Docs / sync-public-api (push) Waiting to run
Build: Benchmark Image / build (push) Has been cancelled
fix(MongoDB Node): Validate update key value type (#31371)
2026-05-29 13:40:03 +00:00

154 lines
4.7 KiB
TypeScript

import type { INode } from 'n8n-workflow';
import { prepareItems } from './GenericFunctions';
const mockNode = { name: 'MongoDB', type: 'n8n-nodes-base.mongoDb' } as INode;
describe('MongoDB Node: Generic Functions', () => {
describe('prepareItems', () => {
it('should select fields', () => {
const items = [{ json: { name: 'John', age: 30 } }, { json: { name: 'Jane', age: 25 } }];
const fields = ['name'];
const result = prepareItems({ items, fields, node: mockNode });
expect(result).toEqual([{ name: 'John' }, { name: 'Jane' }]);
});
it('should add updateKey to selected fields', () => {
const items = [{ json: { name: 'John', age: 30 } }, { json: { name: 'Jane', age: 25 } }];
const fields = ['age'];
const updateKey = 'name';
const result = prepareItems({ items, fields, updateKey, node: mockNode });
expect(result).toEqual([
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
]);
});
it('should handle dot notation', () => {
const items = [{ json: { user: { name: 'John' } } }, { json: { user: { name: 'Jane' } } }];
const fields = ['user.name'];
const useDotNotation = true;
const result = prepareItems({
items,
fields,
updateKey: '',
useDotNotation,
node: mockNode,
});
expect(result).toEqual([{ user: { name: 'John' } }, { user: { name: 'Jane' } }]);
});
it('should parse dates', () => {
const items = [
{ json: { date: '2023-10-01T00:00:00Z' } },
{ json: { date: '2023-10-02T00:00:00Z' } },
];
const fields = ['date'];
const dateFields = ['date'];
const useDotNotation = false;
const isUpdate = false;
const result = prepareItems({
items,
fields,
updateKey: '',
useDotNotation,
dateFields,
isUpdate,
node: mockNode,
});
expect(result).toEqual([
{ date: new Date('2023-10-01T00:00:00Z') },
{ date: new Date('2023-10-02T00:00:00Z') },
]);
});
describe('updateKey value validation', () => {
it('throws when the updateKey value is a plain object', () => {
const items = [{ json: { id: { $regex: '^a' }, value: 'x' } }];
const args = { items, fields: ['value'], updateKey: 'id', node: mockNode };
expect(() => prepareItems(args)).toThrow(/must be a string, number, boolean, or date/);
});
it('throws when the updateKey value is an array', () => {
const items = [{ json: { id: ['a', 'b'], value: 'x' } }];
const args = { items, fields: ['value'], updateKey: 'id', node: mockNode };
expect(() => prepareItems(args)).toThrow();
});
it('drops items where useDotNotation would resolve the updateKey to a non-scalar', () => {
// The data-filter step in prepareItems uses bracket access on the dotted key,
// so items whose dot path resolves to an object are excluded before the map loop
// runs. No operator-shaped value reaches the driver.
const items = [{ json: { user: { id: { $gt: 1 } }, value: 'x' } }];
const args = {
items,
fields: ['value'],
updateKey: 'user.id',
useDotNotation: true,
node: mockNode,
};
const result = prepareItems(args);
expect(result).toEqual([]);
});
it('passes a string updateKey value through unchanged even when its content looks like JSON', () => {
const items = [{ json: { id: '{"$regex":"^a"}', value: 'x' } }];
const args = { items, fields: ['value'], updateKey: 'id', node: mockNode };
const result = prepareItems(args);
expect(result).toEqual([{ id: '{"$regex":"^a"}', value: 'x' }]);
});
it('accepts number, boolean, and null updateKey values', () => {
const items = [
{ json: { id: 1, value: 'a' } },
{ json: { id: true, value: 'b' } },
{ json: { id: null, value: 'c' } },
];
const args = { items, fields: ['value'], updateKey: 'id', node: mockNode };
expect(() => prepareItems(args)).not.toThrow();
});
it('accepts Date updateKey values', () => {
const items = [{ json: { id: new Date('2024-01-01'), value: 'a' } }];
const args = { items, fields: ['value'], updateKey: 'id', node: mockNode };
expect(() => prepareItems(args)).not.toThrow();
});
});
it('should handle updates', () => {
// Should keep dot notation in result to not overwrite the original values
const items = [
{ json: { id: 1, user: { name: 'John', age: 30 } } },
{ json: { id: 2, user: { name: 'Jane', age: 25 } } },
];
const fields = ['user.name'];
const useDotNotation = true;
const isUpdate = true;
const result = prepareItems({
items,
fields,
updateKey: '',
useDotNotation,
dateFields: [],
isUpdate,
node: mockNode,
});
expect(result).toEqual([{ 'user.name': 'John' }, { 'user.name': 'Jane' }]);
});
});
});