n8n/packages/cli/test/integration/public-api/executions.test.ts
Sandra Zollner ccd04b0edf
Some checks are pending
Build: Benchmark Image / build (push) Waiting to run
CI: Master (Build, Test, Lint) / Build for Github Cache (push) Waiting to run
CI: Master (Build, Test, Lint) / Unit tests (22.x) (push) Waiting to run
CI: Master (Build, Test, Lint) / Unit tests (24.13.1) (push) Waiting to run
CI: Master (Build, Test, Lint) / Unit tests (25.x) (push) Waiting to run
CI: Master (Build, Test, Lint) / Lint (push) Waiting to run
CI: Master (Build, Test, Lint) / Performance (push) Waiting to run
CI: Master (Build, Test, Lint) / Notify Slack on failure (push) Blocked by required conditions
Util: Sync API Docs / sync-public-api (push) Waiting to run
feat(core): Improve public API middleware to handle different error types (#27562)
2026-03-31 14:06:23 +00:00

988 lines
32 KiB
TypeScript

import {
createManyWorkflows,
createTeamProject,
createWorkflow,
mockInstance,
shareWorkflowWithUsers,
testDb,
} from '@n8n/backend-test-utils';
import type { ExecutionEntity, User } from '@n8n/db';
import { Container } from '@n8n/di';
import { type ExecutionStatus } from 'n8n-workflow';
import {
createAnnotationTags,
createdExecutionWithStatus,
createErrorExecution,
createExecution,
createManyExecutions,
createSuccessfulExecution,
} from '../shared/db/executions';
import { createMemberWithApiKey, createOwnerWithApiKey } from '../shared/db/users';
import type { SuperAgentTest } from '../shared/types';
import * as utils from '../shared/utils/';
import type { ActiveWorkflowManager } from '@/active-workflow-manager';
import { ExecutionService } from '@/executions/execution.service';
import { Telemetry } from '@/telemetry';
import { QueuedExecutionRetryError } from '@/errors/queued-execution-retry.error';
import { AbortedExecutionRetryError } from '@/errors/aborted-execution-retry.error';
import { ConflictError } from '@/errors/response-errors/conflict.error';
let owner: User;
let user1: User;
let user2: User;
let authOwnerAgent: SuperAgentTest;
let authUser1Agent: SuperAgentTest;
let authUser2Agent: SuperAgentTest;
let workflowRunner: ActiveWorkflowManager;
mockInstance(Telemetry);
const testServer = utils.setupTestServer({ endpointGroups: ['publicApi'] });
beforeAll(async () => {
owner = await createOwnerWithApiKey();
user1 = await createMemberWithApiKey();
user2 = await createMemberWithApiKey();
// TODO: mock BinaryDataService instead
await utils.initBinaryDataService();
await utils.initNodeTypes();
workflowRunner = await utils.initActiveWorkflowManager();
});
beforeEach(async () => {
await testDb.truncate([
'SharedCredentials',
'SharedWorkflow',
'WorkflowEntity',
'CredentialsEntity',
'ExecutionEntity',
'ExecutionAnnotation',
'AnnotationTagEntity',
'AnnotationTagMapping',
'Settings',
]);
authOwnerAgent = testServer.publicApiAgentFor(owner);
authUser1Agent = testServer.publicApiAgentFor(user1);
authUser2Agent = testServer.publicApiAgentFor(user2);
});
afterEach(async () => {
await workflowRunner?.removeAll();
});
const testWithAPIKey =
(method: 'get' | 'post' | 'put' | 'delete', url: string, apiKey: string | null) => async () => {
void authOwnerAgent.set({ 'X-N8N-API-KEY': apiKey });
const response = await authOwnerAgent[method](url);
expect(response.statusCode).toBe(401);
};
describe('GET /executions/:id', () => {
test('should fail due to missing API Key', testWithAPIKey('get', '/executions/1', null));
test('should fail due to invalid API Key', testWithAPIKey('get', '/executions/1', 'abcXYZ'));
test('owner should be able to get an execution owned by him', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authOwnerAgent.get(`/executions/${execution.id}`);
expect(response.statusCode).toBe(200);
const {
id,
finished,
mode,
retryOf,
retrySuccessId,
startedAt,
stoppedAt,
workflowId,
waitTill,
} = response.body;
expect(id).toBeDefined();
expect(finished).toBe(true);
expect(mode).toEqual(execution.mode);
expect(retrySuccessId).toBeNull();
expect(retryOf).toBeNull();
expect(startedAt).not.toBeNull();
expect(stoppedAt).not.toBeNull();
expect(workflowId).toBe(execution.workflowId);
expect(waitTill).toBeNull();
});
test('owner should be able to read executions of other users', async () => {
const workflow = await createWorkflow({}, user1);
const execution = await createSuccessfulExecution(workflow);
const response = await authOwnerAgent.get(`/executions/${execution.id}`);
expect(response.statusCode).toBe(200);
});
test('member should be able to fetch his own executions', async () => {
const workflow = await createWorkflow({}, user1);
const execution = await createSuccessfulExecution(workflow);
const response = await authUser1Agent.get(`/executions/${execution.id}`);
expect(response.statusCode).toBe(200);
});
test('member should not be able to fetch custom data when includeData is not set', async () => {
const workflow = await createWorkflow({}, user1);
const execution = await createExecution(
{
finished: true,
status: 'success',
metadata: [
{ key: 'test1', value: 'value1' },
{ key: 'test2', value: 'value2' },
],
},
workflow,
);
const response = await authUser1Agent.get(`/executions/${execution.id}`);
expect(response.statusCode).toBe(200);
expect(response.body.customData).toBeUndefined();
});
test('member should be able to fetch custom data when includeData=true', async () => {
const workflow = await createWorkflow({}, user1);
const execution = await createExecution(
{
finished: true,
status: 'success',
metadata: [
{ key: 'test1', value: 'value1' },
{ key: 'test2', value: 'value2' },
],
},
workflow,
);
const response = await authUser1Agent.get(`/executions/${execution.id}?includeData=true`);
expect(response.statusCode).toBe(200);
expect(response.body.customData).toEqual({
test1: 'value1',
test2: 'value2',
});
});
test('member should not get an execution of another user without the workflow being shared', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authUser1Agent.get(`/executions/${execution.id}`);
expect(response.statusCode).toBe(404);
});
test('member should be able to fetch executions of workflows shared with him', async () => {
testServer.license.enable('feat:sharing');
const workflow = await createWorkflow({}, user1);
const execution = await createSuccessfulExecution(workflow);
await shareWorkflowWithUsers(workflow, [user2]);
const response = await authUser2Agent.get(`/executions/${execution.id}`);
expect(response.statusCode).toBe(200);
});
});
describe('DELETE /executions/:id', () => {
test('should fail due to missing API Key', testWithAPIKey('delete', '/executions/1', null));
test('should fail due to invalid API Key', testWithAPIKey('delete', '/executions/1', 'abcXYZ'));
test('should delete an execution', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authOwnerAgent.delete(`/executions/${execution.id}`);
expect(response.statusCode).toBe(200);
const {
id,
finished,
mode,
retryOf,
retrySuccessId,
startedAt,
stoppedAt,
workflowId,
waitTill,
} = response.body;
expect(id).toBeDefined();
expect(finished).toBe(true);
expect(mode).toEqual(execution.mode);
expect(retrySuccessId).toBeNull();
expect(retryOf).toBeNull();
expect(startedAt).not.toBeNull();
expect(stoppedAt).not.toBeNull();
expect(workflowId).toBe(execution.workflowId);
expect(waitTill).toBeNull();
await authOwnerAgent.get(`/executions/${execution.id}`).expect(404);
});
});
describe('POST /executions/:id/retry', () => {
test('should fail due to missing API Key', testWithAPIKey('post', '/executions/1/retry', null));
test(
'should fail due to invalid API Key',
testWithAPIKey('post', '/executions/1/retry', 'abcXYZ'),
);
test('should retry an execution', async () => {
const mockedExecutionResponse = { status: 'waiting' } as any;
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'retry')
.mockResolvedValue(mockedExecutionResponse);
const workflow = await createWorkflow({}, user1);
const execution = await createSuccessfulExecution(workflow);
const response = await authUser1Agent.post(`/executions/${execution.id}/retry`);
expect(response.statusCode).toBe(200);
expect(response.body).toEqual(mockedExecutionResponse);
executionServiceSpy.mockRestore();
});
test('should return 404 when execution is not found', async () => {
const nonExistentExecutionId = 99999999;
const response = await authUser1Agent.post(`/executions/${nonExistentExecutionId}/retry`);
expect(response.statusCode).toBe(404);
expect(response.body.message).toBe('Not Found');
});
test('should return 409 when trying to retry a queued execution', async () => {
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'retry')
.mockRejectedValue(new QueuedExecutionRetryError());
const workflow = await createWorkflow({}, user1);
const execution = await createExecution({ status: 'new', finished: false }, workflow);
const response = await authUser1Agent.post(`/executions/${execution.id}/retry`);
expect(response.statusCode).toBe(409);
expect(response.body.message).toBe(
'Execution is queued to run (not yet started) so it cannot be retried',
);
executionServiceSpy.mockRestore();
});
test('should return 409 when trying to retry an aborted execution without execution data', async () => {
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'retry')
.mockRejectedValue(new AbortedExecutionRetryError());
const workflow = await createWorkflow({}, user1);
const execution = await createExecution(
{
status: 'error',
finished: false,
data: JSON.stringify({ executionData: null }),
},
workflow,
);
const response = await authUser1Agent.post(`/executions/${execution.id}/retry`);
expect(response.statusCode).toBe(409);
expect(response.body.message).toBe(
'The execution was aborted before starting, so it cannot be retried',
);
executionServiceSpy.mockRestore();
});
test('should return 409 when trying to retry a finished execution', async () => {
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'retry')
.mockRejectedValue(new ConflictError('The execution succeeded, so it cannot be retried.'));
const workflow = await createWorkflow({}, user1);
const execution = await createExecution(
{
status: 'success',
finished: true,
data: JSON.stringify({ executionData: null }),
},
workflow,
);
const response = await authUser1Agent.post(`/executions/${execution.id}/retry`);
expect(response.statusCode).toBe(409);
expect(response.body.message).toBe('The execution succeeded, so it cannot be retried.');
executionServiceSpy.mockRestore();
});
});
describe('GET /executions', () => {
test('should fail due to missing API Key', testWithAPIKey('get', '/executions', null));
test('should fail due to invalid API Key', testWithAPIKey('get', '/executions', 'abcXYZ'));
test('should paginate two executions', async () => {
const workflow = await createWorkflow({}, owner);
const firstSuccessfulExecution = await createSuccessfulExecution(workflow);
const secondSuccessfulExecution = await createSuccessfulExecution(workflow);
await createErrorExecution(workflow);
const firstExecutionResponse = await authOwnerAgent.get('/executions').query({
status: 'success',
limit: 1,
});
expect(firstExecutionResponse.statusCode).toBe(200);
expect(firstExecutionResponse.body.data.length).toBe(1);
expect(firstExecutionResponse.body.nextCursor).toBeDefined();
const secondExecutionResponse = await authOwnerAgent.get('/executions').query({
status: 'success',
limit: 1,
cursor: firstExecutionResponse.body.nextCursor,
});
expect(secondExecutionResponse.statusCode).toBe(200);
expect(secondExecutionResponse.body.data.length).toBe(1);
expect(secondExecutionResponse.body.nextCursor).toBeNull();
const successfulExecutions = [firstSuccessfulExecution, secondSuccessfulExecution];
const executions = [...firstExecutionResponse.body.data, ...secondExecutionResponse.body.data];
for (let i = 0; i < executions.length; i++) {
const {
id,
finished,
mode,
retryOf,
retrySuccessId,
startedAt,
stoppedAt,
workflowId,
waitTill,
status,
} = executions[i];
expect(id).toBeDefined();
expect(finished).toBe(true);
expect(mode).toEqual(successfulExecutions[i].mode);
expect(retrySuccessId).toBeNull();
expect(retryOf).toBeNull();
expect(startedAt).not.toBeNull();
expect(stoppedAt).not.toBeNull();
expect(workflowId).toBe(successfulExecutions[i].workflowId);
expect(waitTill).toBeNull();
expect(status).toBe(successfulExecutions[i].status);
}
});
describe('with query status', () => {
type AllowedQueryStatus = 'canceled' | 'error' | 'running' | 'success' | 'waiting';
test.each`
queryStatus | entityStatus
${'canceled'} | ${'canceled'}
${'error'} | ${'error'}
${'error'} | ${'crashed'}
${'running'} | ${'running'}
${'success'} | ${'success'}
${'waiting'} | ${'waiting'}
`(
'should retrieve all $queryStatus executions',
async ({
queryStatus,
entityStatus,
}: { queryStatus: AllowedQueryStatus; entityStatus: ExecutionStatus }) => {
const workflow = await createWorkflow({}, owner);
await createdExecutionWithStatus(workflow, queryStatus === 'success' ? 'error' : 'success');
if (queryStatus !== 'running') {
// ensure there is a running execution that gets excluded unless filtering by `running`
await createdExecutionWithStatus(workflow, 'running');
}
const expectedExecution = await createdExecutionWithStatus(workflow, entityStatus);
const response = await authOwnerAgent.get('/executions').query({
status: queryStatus,
});
expect(response.statusCode).toBe(200);
expect(response.body.data.length).toBe(1);
expect(response.body.nextCursor).toBe(null);
const { id, status } = response.body.data[0];
expect(id).toBeDefined();
expect(status).toBe(expectedExecution.status);
},
);
});
test('should retrieve all executions of specific workflow', async () => {
const [workflow, workflow2] = await createManyWorkflows(2, {}, owner);
const savedExecutions = await createManyExecutions(2, workflow, createSuccessfulExecution);
await createManyExecutions(2, workflow2, createSuccessfulExecution);
const response = await authOwnerAgent.get('/executions').query({
workflowId: workflow.id,
});
expect(response.statusCode).toBe(200);
expect(response.body.data.length).toBe(2);
expect(response.body.nextCursor).toBe(null);
for (const execution of response.body.data) {
const {
id,
finished,
mode,
retryOf,
retrySuccessId,
startedAt,
stoppedAt,
workflowId,
waitTill,
status,
} = execution;
expect(savedExecutions.some((exec) => exec.id === id)).toBe(true);
expect(finished).toBe(true);
expect(mode).toBeDefined();
expect(retrySuccessId).toBeNull();
expect(retryOf).toBeNull();
expect(startedAt).not.toBeNull();
expect(stoppedAt).not.toBeNull();
expect(workflowId).toBe(workflow.id);
expect(waitTill).toBeNull();
expect(status).toBe(execution.status);
}
});
test('should return executions filtered by project ID', async () => {
/**
* Arrange
*/
const [firstProject, secondProject] = await Promise.all([
createTeamProject(),
createTeamProject(),
]);
const [firstWorkflow, secondWorkflow] = await Promise.all([
createWorkflow({}, firstProject),
createWorkflow({}, secondProject),
]);
const [firstExecution, secondExecution, _] = await Promise.all([
createExecution({}, firstWorkflow),
createExecution({}, firstWorkflow),
createExecution({}, secondWorkflow),
]);
/**
* Act
*/
const response = await authOwnerAgent.get('/executions').query({
projectId: firstProject.id,
});
/**
* Assert
*/
expect(response.statusCode).toBe(200);
expect(response.body.data.length).toBe(2);
expect(response.body.nextCursor).toBeNull();
expect(response.body.data.map((execution: ExecutionEntity) => execution.id)).toEqual(
expect.arrayContaining([firstExecution.id, secondExecution.id]),
);
});
test('owner should retrieve all executions regardless of ownership', async () => {
const [firstWorkflowForUser1, secondWorkflowForUser1] = await createManyWorkflows(2, {}, user1);
await createManyExecutions(2, firstWorkflowForUser1, createSuccessfulExecution);
await createManyExecutions(2, secondWorkflowForUser1, createSuccessfulExecution);
const [firstWorkflowForUser2, secondWorkflowForUser2] = await createManyWorkflows(2, {}, user2);
await createManyExecutions(2, firstWorkflowForUser2, createSuccessfulExecution);
await createManyExecutions(2, secondWorkflowForUser2, createSuccessfulExecution);
const response = await authOwnerAgent.get('/executions');
expect(response.statusCode).toBe(200);
expect(response.body.data.length).toBe(8);
expect(response.body.nextCursor).toBe(null);
});
test('member should not see executions of workflows not shared with him', async () => {
const [firstWorkflowForUser1, secondWorkflowForUser1] = await createManyWorkflows(2, {}, user1);
await createManyExecutions(2, firstWorkflowForUser1, createSuccessfulExecution);
await createManyExecutions(2, secondWorkflowForUser1, createSuccessfulExecution);
const [firstWorkflowForUser2, secondWorkflowForUser2] = await createManyWorkflows(2, {}, user2);
await createManyExecutions(2, firstWorkflowForUser2, createSuccessfulExecution);
await createManyExecutions(2, secondWorkflowForUser2, createSuccessfulExecution);
const response = await authUser1Agent.get('/executions');
expect(response.statusCode).toBe(200);
expect(response.body.data.length).toBe(4);
expect(response.body.nextCursor).toBe(null);
});
test('member should also see executions of workflows shared with him', async () => {
testServer.license.enable('feat:sharing');
const [firstWorkflowForUser1, secondWorkflowForUser1] = await createManyWorkflows(2, {}, user1);
await createManyExecutions(2, firstWorkflowForUser1, createSuccessfulExecution);
await createManyExecutions(2, secondWorkflowForUser1, createSuccessfulExecution);
const [firstWorkflowForUser2, secondWorkflowForUser2] = await createManyWorkflows(2, {}, user2);
await createManyExecutions(2, firstWorkflowForUser2, createSuccessfulExecution);
await createManyExecutions(2, secondWorkflowForUser2, createSuccessfulExecution);
await shareWorkflowWithUsers(firstWorkflowForUser2, [user1]);
const response = await authUser1Agent.get('/executions');
expect(response.statusCode).toBe(200);
expect(response.body.data.length).toBe(6);
expect(response.body.nextCursor).toBe(null);
});
});
describe('GET /executions/:id/tags', () => {
test('should fail due to missing API Key', testWithAPIKey('get', '/executions/1/tags', null));
test('should fail due to invalid API Key', testWithAPIKey('get', '/executions/1/tags', 'abcXYZ'));
test('should return 404 for non-existent execution', async () => {
const response = await authOwnerAgent.get('/executions/999/tags');
expect(response.statusCode).toBe(404);
});
test('should return empty array for execution with no tags', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authOwnerAgent.get(`/executions/${execution.id}/tags`);
expect(response.statusCode).toBe(200);
expect(response.body).toEqual([]);
});
test('member should not get tags from execution in inaccessible workflow', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authUser1Agent.get(`/executions/${execution.id}/tags`);
expect(response.statusCode).toBe(404);
});
});
describe('PUT /executions/:id/tags', () => {
test('should fail due to missing API Key', testWithAPIKey('put', '/executions/1/tags', null));
test('should fail due to invalid API Key', testWithAPIKey('put', '/executions/1/tags', 'abcXYZ'));
test('should return 404 for non-existent execution', async () => {
const response = await authOwnerAgent.put('/executions/999/tags').send([]);
expect(response.statusCode).toBe(404);
});
test('should set tags on execution', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const [tag] = await createAnnotationTags(['dataset']);
const response = await authOwnerAgent
.put(`/executions/${execution.id}/tags`)
.send([{ id: tag.id }]);
expect(response.statusCode).toBe(200);
expect(response.body).toHaveLength(1);
expect(response.body[0].name).toBe('dataset');
expect(response.body[0].id).toBe(tag.id);
});
test('should replace existing tags', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const [tag1, tag2] = await createAnnotationTags(['tag1', 'tag2']);
// Set first tag
await authOwnerAgent.put(`/executions/${execution.id}/tags`).send([{ id: tag1.id }]);
// Replace with second tag
const response = await authOwnerAgent
.put(`/executions/${execution.id}/tags`)
.send([{ id: tag2.id }]);
expect(response.statusCode).toBe(200);
expect(response.body).toHaveLength(1);
expect(response.body[0].name).toBe('tag2');
});
test('should clear tags with empty array', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const [tag] = await createAnnotationTags(['dataset']);
// Set tag first
await authOwnerAgent.put(`/executions/${execution.id}/tags`).send([{ id: tag.id }]);
// Clear with empty array
const response = await authOwnerAgent.put(`/executions/${execution.id}/tags`).send([]);
expect(response.statusCode).toBe(200);
expect(response.body).toEqual([]);
});
test('should return 404 for non-existent tag IDs', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authOwnerAgent
.put(`/executions/${execution.id}/tags`)
.send([{ id: 'nonexistent-tag-id' }]);
expect(response.statusCode).toBe(404);
expect(response.body.message).toBe('Some tags not found');
});
test('member should not update tags on execution in inaccessible workflow', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const response = await authUser1Agent.put(`/executions/${execution.id}/tags`).send([]);
expect(response.statusCode).toBe(404);
});
test('GET should return tags after PUT', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createSuccessfulExecution(workflow);
const [tag1, tag2] = await createAnnotationTags(['important', 'reviewed']);
// Set tags
await authOwnerAgent
.put(`/executions/${execution.id}/tags`)
.send([{ id: tag1.id }, { id: tag2.id }]);
// GET should return the same tags
const response = await authOwnerAgent.get(`/executions/${execution.id}/tags`);
expect(response.statusCode).toBe(200);
expect(response.body).toHaveLength(2);
expect(response.body.map((t: { name: string }) => t.name).sort()).toEqual([
'important',
'reviewed',
]);
});
});
describe('POST /executions/:id/stop', () => {
test('should fail due to missing API Key', testWithAPIKey('post', '/executions/1/stop', null));
test(
'should fail due to invalid API Key',
testWithAPIKey('post', '/executions/1/stop', 'abcXYZ'),
);
test('should stop a running execution', async () => {
const mockedStopResponse = {
mode: 'manual',
startedAt: new Date().toISOString(),
stoppedAt: new Date().toISOString(),
finished: false,
status: 'canceled',
} as any;
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stop')
.mockResolvedValue({
...mockedStopResponse,
startedAt: new Date(mockedStopResponse.startedAt),
stoppedAt: new Date(mockedStopResponse.stoppedAt),
});
const workflow = await createWorkflow({}, user1);
const execution = await createExecution({ status: 'running', finished: false }, workflow);
const response = await authUser1Agent.post(`/executions/${execution.id}/stop`);
expect(response.statusCode).toBe(200);
expect(response.body).toEqual(mockedStopResponse);
expect(executionServiceSpy).toHaveBeenCalled();
// The execution ID from the route parameter is passed to the service
const calledExecutionId = executionServiceSpy.mock.calls[0][0];
// URL parameters come as strings, so we expect string conversion
expect(String(calledExecutionId)).toBe(execution.id.toString());
executionServiceSpy.mockRestore();
});
test('should return 404 when execution is not found', async () => {
const nonExistentExecutionId = 99999999;
const response = await authUser1Agent.post(`/executions/${nonExistentExecutionId}/stop`);
expect(response.statusCode).toBe(404);
expect(response.body.message).toBe('Not Found');
});
test('member should not be able to stop execution of workflow not shared with them', async () => {
const workflow = await createWorkflow({}, owner);
const execution = await createExecution({ status: 'running', finished: false }, workflow);
const response = await authUser1Agent.post(`/executions/${execution.id}/stop`);
expect(response.statusCode).toBe(404);
expect(response.body.message).toBe('Not Found');
});
test('should allow stopping execution of shared workflow', async () => {
testServer.license.enable('feat:sharing');
const mockedStopResponse = {
mode: 'manual',
startedAt: new Date().toISOString(),
stoppedAt: new Date().toISOString(),
finished: false,
status: 'canceled',
} as any;
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stop')
.mockResolvedValue({
...mockedStopResponse,
startedAt: new Date(mockedStopResponse.startedAt),
stoppedAt: new Date(mockedStopResponse.stoppedAt),
});
const workflow = await createWorkflow({}, user1);
const execution = await createExecution({ status: 'running', finished: false }, workflow);
await shareWorkflowWithUsers(workflow, [user2]);
const response = await authUser2Agent.post(`/executions/${execution.id}/stop`);
expect(response.statusCode).toBe(200);
expect(response.body).toEqual(mockedStopResponse);
executionServiceSpy.mockRestore();
});
});
describe('POST /executions/stop', () => {
test('should fail due to missing API Key', testWithAPIKey('post', '/executions/stop', null));
test('should fail due to invalid API Key', testWithAPIKey('post', '/executions/stop', 'abcXYZ'));
test('should return 400 when status is not provided', async () => {
const response = await authUser1Agent.post('/executions/stop').send({});
expect(response.statusCode).toBe(400);
// OpenAPI validation catches this before our handler validation
expect(response.body.message).toContain('status');
});
test('should return 400 when status is empty array', async () => {
const response = await authUser1Agent.post('/executions/stop').send({ status: [] });
expect(response.statusCode).toBe(400);
expect(response.body.message).toContain('Status filter is required');
expect(response.body.example).toBeDefined();
});
test('should stop multiple running executions', async () => {
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stopMany')
.mockResolvedValue(3);
await createWorkflow({}, user1);
const response = await authUser1Agent
.post('/executions/stop')
.send({ status: ['running', 'waiting'] });
expect(response.statusCode).toBe(200);
expect(response.body).toEqual({ stopped: 3 });
expect(executionServiceSpy).toHaveBeenCalledWith(
{
workflowId: 'all',
status: ['running', 'waiting'],
startedAfter: undefined,
startedBefore: undefined,
},
expect.any(Array),
);
executionServiceSpy.mockRestore();
});
test('should stop executions filtered by workflowId', async () => {
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stopMany')
.mockResolvedValue(2);
const workflow = await createWorkflow({}, user1);
const response = await authUser1Agent
.post('/executions/stop')
.send({ status: ['running'], workflowId: workflow.id });
expect(response.statusCode).toBe(200);
expect(response.body).toEqual({ stopped: 2 });
expect(executionServiceSpy).toHaveBeenCalledWith(
{
workflowId: workflow.id,
status: ['running'],
startedAfter: undefined,
startedBefore: undefined,
},
expect.any(Array),
);
executionServiceSpy.mockRestore();
});
test('should stop executions with date filters', async () => {
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stopMany')
.mockResolvedValue(1);
await createWorkflow({}, user1);
const startedAfter = '2024-01-01T00:00:00.000Z';
const startedBefore = '2024-12-31T23:59:59.999Z';
const response = await authUser1Agent.post('/executions/stop').send({
status: ['running'],
startedAfter,
startedBefore,
});
expect(response.statusCode).toBe(200);
expect(response.body).toEqual({ stopped: 1 });
expect(executionServiceSpy).toHaveBeenCalledWith(
{
workflowId: 'all',
status: ['running'],
startedAfter,
startedBefore,
},
expect.any(Array),
);
executionServiceSpy.mockRestore();
});
test('should validate workflowId access when provided', async () => {
// Create a workflow for user1
const workflow = await createWorkflow({}, user1);
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stopMany')
.mockResolvedValue(1);
// User1 should be able to stop executions in their own workflow
const response = await authUser1Agent
.post('/executions/stop')
.send({ status: ['running'], workflowId: workflow.id });
expect(response.statusCode).toBe(200);
expect(executionServiceSpy).toHaveBeenCalled();
expect(executionServiceSpy.mock.calls[0][0].workflowId).toBe(workflow.id);
executionServiceSpy.mockRestore();
});
test('should return 0 stopped when user has no workflows', async () => {
const executionServiceSpy = jest.spyOn(Container.get(ExecutionService), 'stopMany');
// Create a new user with no workflows
const userWithNoWorkflows = await createMemberWithApiKey();
const authAgentWithNoWorkflows = testServer.publicApiAgentFor(userWithNoWorkflows);
const response = await authAgentWithNoWorkflows
.post('/executions/stop')
.send({ status: ['running'] });
expect(response.statusCode).toBe(200);
expect(response.body).toEqual({ stopped: 0 });
// stopMany should not be called if user has no workflows
expect(executionServiceSpy).not.toHaveBeenCalled();
executionServiceSpy.mockRestore();
});
test('owner should be able to stop executions across all workflows', async () => {
// Create some workflows so owner has workflows to access
await createManyWorkflows(2, {}, owner);
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stopMany')
.mockResolvedValue(5);
const response = await authOwnerAgent
.post('/executions/stop')
.send({ status: ['running', 'waiting'] });
expect(response.statusCode).toBe(200);
expect(response.body).toEqual({ stopped: 5 });
executionServiceSpy.mockRestore();
});
test('member should only stop executions in their accessible workflows', async () => {
testServer.license.enable('feat:sharing');
const executionServiceSpy = jest
.spyOn(Container.get(ExecutionService), 'stopMany')
.mockResolvedValue(2);
const [workflow1, workflow2] = await createManyWorkflows(2, {}, user1);
const workflow3 = await createWorkflow({}, user2);
// Share workflow3 with user1
await shareWorkflowWithUsers(workflow3, [user1]);
const response = await authUser1Agent.post('/executions/stop').send({ status: ['running'] });
expect(response.statusCode).toBe(200);
expect(response.body).toEqual({ stopped: 2 });
// Verify that the service was called with workflow IDs accessible to user1
const calledWithWorkflowIds = executionServiceSpy.mock.calls[0][1];
expect(calledWithWorkflowIds).toContain(workflow1.id);
expect(calledWithWorkflowIds).toContain(workflow2.id);
expect(calledWithWorkflowIds).toContain(workflow3.id);
executionServiceSpy.mockRestore();
});
});