From ee46834915197609cd75ce56fdce2c2e8409f787 Mon Sep 17 00:00:00 2001 From: Robin Braumann <50590409+bjorger@users.noreply.github.com> Date: Thu, 1 Oct 2026 09:16:40 +0000 Subject: [PATCH] fix(editor): Correct the expanded Markdown editor close label (#40041) --- .../N8nMarkdownEditor/MarkdownEditor.test.ts | 14 ++++++++++---- .../@n8n/design-system/src/locale/lang/en.ts | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/packages/frontend/@n8n/design-system/src/components/N8nMarkdownEditor/MarkdownEditor.test.ts b/packages/frontend/@n8n/design-system/src/components/N8nMarkdownEditor/MarkdownEditor.test.ts index 1a839612889..08ebced5261 100644 --- a/packages/frontend/@n8n/design-system/src/components/N8nMarkdownEditor/MarkdownEditor.test.ts +++ b/packages/frontend/@n8n/design-system/src/components/N8nMarkdownEditor/MarkdownEditor.test.ts @@ -255,14 +255,20 @@ describe('components/N8nMarkdownEditor', () => { await waitFor(function waitForExpandedView() { expect(wrapper.getByRole('dialog', { name: 'Markdown editor' })).toBeInTheDocument(); - expect(wrapper.getByRole('button', { name: 'Collapse editor' })).toBeInTheDocument(); + expect(wrapper.getByRole('button', { name: 'Close editor' })).toBeInTheDocument(); expect(wrapper.getByTestId('n8n-markdown-editor-content')).toHaveTextContent( 'Inline content', ); }); + const closeButton = wrapper.getByRole('button', { name: 'Close editor' }); + closeButton.dispatchEvent( + new PointerEvent('pointermove', { bubbles: true, pointerType: 'mouse' }), + ); + expect(await wrapper.findByTestId('tooltip-content')).toHaveTextContent('Close editor'); + editor?.commands.insertContent(' expanded content'); - await fireEvent.click(wrapper.getByRole('button', { name: 'Collapse editor' })); + await fireEvent.click(closeButton); await waitFor(function waitForInlineView() { expect(wrapper.queryByRole('dialog', { name: 'Markdown editor' })).not.toBeInTheDocument(); @@ -311,7 +317,7 @@ describe('components/N8nMarkdownEditor', () => { await waitFor(function waitForExpandedRawEditor() { expect(wrapper.getByTestId('n8n-markdown-editor-raw-content')).toHaveValue('# Raw content'); }); - await user.click(wrapper.getByRole('button', { name: 'Collapse editor' })); + await user.click(wrapper.getByRole('button', { name: 'Close editor' })); await waitFor(function waitForInlineRawEditor() { expect(wrapper.getByTestId('n8n-markdown-editor-raw-content')).toHaveValue('# Raw content'); @@ -331,7 +337,7 @@ describe('components/N8nMarkdownEditor', () => { await waitFor(function waitForExpandedView() { expect(wrapper.getByRole('dialog', { name: 'Markdown editor' })).toBeInTheDocument(); - expect(wrapper.getByRole('button', { name: 'Collapse editor' })).toBeInTheDocument(); + expect(wrapper.getByRole('button', { name: 'Close editor' })).toBeInTheDocument(); }); }); diff --git a/packages/frontend/@n8n/design-system/src/locale/lang/en.ts b/packages/frontend/@n8n/design-system/src/locale/lang/en.ts index 18c07dc0d83..6784e015b2f 100644 --- a/packages/frontend/@n8n/design-system/src/locale/lang/en.ts +++ b/packages/frontend/@n8n/design-system/src/locale/lang/en.ts @@ -262,7 +262,7 @@ export default { 'markdownEditor.expand': 'Expand editor', 'markdownEditor.collapse': 'Collapse editor', 'markdownEditor.openExpandedView': 'Expand editor', - 'markdownEditor.closeExpandedView': 'Collapse editor', + 'markdownEditor.closeExpandedView': 'Close editor', 'markdownEditor.expandedViewTitle': 'Markdown editor', 'markdownEditor.linkDialogTitle': 'Add link', 'markdownEditor.linkUrl': 'Link URL',