github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-10-19 16:55:02 +02:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity Graph

fix(core): Validate data table sort columns

Browse Source
This commit is contained in:
n8n-cat-bot[bot] 2026-09-28 10:21:25 +00:00
parent e065f78d1e
commit ca1c7a9801
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cli/src/modules/data-table/data-table.controller.ts
View File

@ -299,6 +299,8 @@ export class DataTableController {
} catch (e: unknown) {
if (e instanceof DataTableNotFoundError) {
throw new NotFoundError(e.message);
} else if (e instanceof DataTableValidationError) {
throw new BadRequestError(e.message);
} else if (e instanceof Error) {
throw new InternalServerError(e.message, e);
} else {

9
packages/cli/src/modules/data-table/data-table.service.ts
View File

@ -335,6 +335,15 @@ export class DataTableService {
return await this.dataTableColumnRepository.manager.transaction(async (em) => {
const columns = await this.dataTableColumnRepository.getColumns(dataTableId, em);
if (dto.sortBy) {
const [sortColumn] = dto.sortBy;
if (
!columns.some(({ name }) => name === sortColumn) &&
!Object.hasOwn(DATA_TABLE_SYSTEM_COLUMN_TYPE_MAP, sortColumn)
) {
throw new DataTableValidationError(`unknown column name '${sortColumn}'`);
}
}
const transformedDto = dto.filter
? { ...dto, filter: this.validateAndTransformFilters(dto.filter, columns) }
: dto;