github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-10-17 05:29:44 +02:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity Graph

fix(Email Trigger (IMAP) Node): Check the mailbox when the trigger activates (#41013)

Browse Source
This commit is contained in:
Bernhard Wittmann 2026-10-16 13:10:25 +00:00 committed by GitHub
parent 7001886432
commit a6719b8db7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 47 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.test.ts
View File

@ -303,25 +303,53 @@ describe('EmailReadImapV2', () => {
});
});
describe('catching up after a gap', () => {
it('looks at the mailbox when it has processed mail before', async () => {
staticData.lastMessageUid = 42;
const connection = createConnection();
connectMock.mockResolvedValueOnce(connection);
describe('catching up on activation', () => {
// Mail that landed while the workflow was inactive sends no arrival event.
it.each([
{
case: 'mail processed before',
typeVersion: 2.1,
lastMessageUid: 42,
options: {},
criteria: ['UNSEEN', ['UID', '42:*']],
},
{
case: 'a first activation',
typeVersion: 2.1,
lastMessageUid: undefined,
options: {},
criteria: ['UNSEEN', ['SINCE', '13-Oct-2026']],
},
{
case: 'an untracked last message id',
typeVersion: 2.1,
lastMessageUid: 42,
options: { trackLastMessageId: false },
criteria: ['UNSEEN'],
},
{
case: 'version 2',
typeVersion: 2,
lastMessageUid: 42,
options: {},
criteria: ['UNSEEN'],
},
])(
'searches the mailbox after $case',
async ({ typeVersion, lastMessageUid, options, criteria }) => {
vi.setSystemTime(new Date('2026-10-13T12:00:00Z'));
triggerFunctions.getNode.mockReturnValue(mock<INode>({ typeVersion }));
staticData.lastMessageUid = lastMessageUid;
const connection = createConnection();
connectMock.mockResolvedValueOnce(connection);
await startTrigger();
await startTrigger(options);
expect(connection.catchUp).toHaveBeenCalledTimes(1);
await arrive(connection, 'unknown');
expect(connection.catchUp).toHaveBeenCalledTimes(1);
});
it('leaves the mailbox alone on a first activation', async () => {
const connection = createConnection();
connectMock.mockResolvedValueOnce(connection);
await startTrigger();
expect(connection.catchUp).not.toHaveBeenCalled();
});
expect(fetched).toHaveBeenCalledWith(expect.objectContaining({ searchCriteria: criteria }));
},
);
});
describe('credential test', () => {

3
packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.ts
View File

@ -342,7 +342,8 @@ export class EmailReadImapV2 implements INodeType {
connection.onArrival(async ({ count }) => await fetchNewEmails(connection, count));
if (staticData.lastMessageUid !== undefined) connection.catchUp();
// Mail that landed while the trigger was inactive sends no arrival event.
connection.catchUp();
connection.onFlags((info) => {
this.logger.debug(`Email Read Imap:update ${info.seq}`, { uid: info.uid });