From 956dd09fcc63eeba0c97932b00da23d4e239d8c8 Mon Sep 17 00:00:00 2001 From: Alex Grozav Date: Fri, 31 Oct 2025 13:18:42 +0200 Subject: [PATCH] refactor(editor): Extract remaining `runData` code into features/ndv/runData (no-changelog) (#21283) --- .../usePushConnection/handlers/nodeExecuteAfterData.ts | 2 +- .../src/features/ndv/runData/components/RunData.test.ts | 2 +- .../src/features/ndv/runData/components/RunData.vue | 2 +- .../features/ndv/runData/components/VirtualSchema.test.ts | 2 +- .../src/features/ndv/runData/components/VirtualSchema.vue | 2 +- .../ndv/runData/schemaPreview.api.test.ts} | 2 +- .../ndv/runData/schemaPreview.api.ts} | 0 .../ndv/runData}/schemaPreview.store.test.ts | 8 ++++---- .../ndv/runData}/schemaPreview.store.ts | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) rename packages/frontend/editor-ui/src/{api/schemaPreview.test.ts => features/ndv/runData/schemaPreview.api.test.ts} (97%) rename packages/frontend/editor-ui/src/{api/schemaPreview.ts => features/ndv/runData/schemaPreview.api.ts} (100%) rename packages/frontend/editor-ui/src/{stores => features/ndv/runData}/schemaPreview.store.test.ts (95%) rename packages/frontend/editor-ui/src/{stores => features/ndv/runData}/schemaPreview.store.ts (97%) diff --git a/packages/frontend/editor-ui/src/composables/usePushConnection/handlers/nodeExecuteAfterData.ts b/packages/frontend/editor-ui/src/composables/usePushConnection/handlers/nodeExecuteAfterData.ts index 166ba7a3d83..7d67b743005 100644 --- a/packages/frontend/editor-ui/src/composables/usePushConnection/handlers/nodeExecuteAfterData.ts +++ b/packages/frontend/editor-ui/src/composables/usePushConnection/handlers/nodeExecuteAfterData.ts @@ -1,5 +1,5 @@ import type { NodeExecuteAfterData } from '@n8n/api-types/push/execution'; -import { useSchemaPreviewStore } from '@/stores/schemaPreview.store'; +import { useSchemaPreviewStore } from '@/features/ndv/runData/schemaPreview.store'; import { useWorkflowsStore } from '@/stores/workflows.store'; /** diff --git a/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.test.ts b/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.test.ts index b6c0912ceaa..ac619e3828c 100644 --- a/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.test.ts +++ b/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.test.ts @@ -18,7 +18,7 @@ import { waitFor } from '@testing-library/vue'; import type { INodeExecutionData, ITaskData, ITaskMetadata } from 'n8n-workflow'; import { setActivePinia } from 'pinia'; import { useNodeTypesStore } from '@/stores/nodeTypes.store'; -import { useSchemaPreviewStore } from '@/stores/schemaPreview.store'; +import { useSchemaPreviewStore } from '@/features/ndv/runData/schemaPreview.store'; import { useNDVStore } from '@/features/ndv/shared/ndv.store'; const MOCK_EXECUTION_URL = 'execution.url/123'; diff --git a/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.vue b/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.vue index 83582ca924f..122c80d0b16 100644 --- a/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.vue +++ b/packages/frontend/editor-ui/src/features/ndv/runData/components/RunData.vue @@ -66,7 +66,7 @@ import isEqual from 'lodash/isEqual'; import isObject from 'lodash/isObject'; import { storeToRefs } from 'pinia'; import { useRoute, useRouter } from 'vue-router'; -import { useSchemaPreviewStore } from '@/stores/schemaPreview.store'; +import { useSchemaPreviewStore } from '@/features/ndv/runData/schemaPreview.store'; import { asyncComputed } from '@vueuse/core'; import ViewSubExecution from '@/features/execution/executions/components/ViewSubExecution.vue'; import RunDataItemCount from './RunDataItemCount.vue'; diff --git a/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.test.ts b/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.test.ts index 53bba423587..0c7a6de7c5a 100644 --- a/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.test.ts +++ b/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.test.ts @@ -31,7 +31,7 @@ import { setActivePinia } from 'pinia'; import { mock } from 'vitest-mock-extended'; import { defaultSettings } from '@/__tests__/defaults'; import { usePostHog } from '@/stores/posthog.store'; -import { useSchemaPreviewStore } from '@/stores/schemaPreview.store'; +import { useSchemaPreviewStore } from '@/features/ndv/runData/schemaPreview.store'; import { useSettingsStore } from '@/stores/settings.store'; const mockNode1 = createTestNode({ diff --git a/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.vue b/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.vue index f2ff68baad6..85cbe9f0948 100644 --- a/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.vue +++ b/packages/frontend/editor-ui/src/features/ndv/runData/components/VirtualSchema.vue @@ -38,7 +38,7 @@ import MappingPill from './MappingPill.vue'; import { EnterpriseEditionFeature, PLACEHOLDER_FILLED_AT_EXECUTION_TIME } from '@/constants'; import useEnvironmentsStore from '@/features/settings/environments.ee/environments.store'; -import { useSchemaPreviewStore } from '@/stores/schemaPreview.store'; +import { useSchemaPreviewStore } from '@/features/ndv/runData/schemaPreview.store'; import { useSettingsStore } from '@/stores/settings.store'; import { isEmpty } from '@/utils/typesUtils'; import { asyncComputed } from '@vueuse/core'; diff --git a/packages/frontend/editor-ui/src/api/schemaPreview.test.ts b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.api.test.ts similarity index 97% rename from packages/frontend/editor-ui/src/api/schemaPreview.test.ts rename to packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.api.test.ts index cf14e214132..777b9d85162 100644 --- a/packages/frontend/editor-ui/src/api/schemaPreview.test.ts +++ b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.api.test.ts @@ -1,4 +1,4 @@ -import { getSchemaPreview } from './schemaPreview'; +import { getSchemaPreview } from './schemaPreview.api'; import * as apiUtils from '@n8n/rest-api-client'; vi.mock('@n8n/rest-api-client'); diff --git a/packages/frontend/editor-ui/src/api/schemaPreview.ts b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.api.ts similarity index 100% rename from packages/frontend/editor-ui/src/api/schemaPreview.ts rename to packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.api.ts diff --git a/packages/frontend/editor-ui/src/stores/schemaPreview.store.test.ts b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.store.test.ts similarity index 95% rename from packages/frontend/editor-ui/src/stores/schemaPreview.store.test.ts rename to packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.store.test.ts index d22b5b23420..eeaccc3a226 100644 --- a/packages/frontend/editor-ui/src/stores/schemaPreview.store.test.ts +++ b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.store.test.ts @@ -1,14 +1,14 @@ import { createPinia, setActivePinia } from 'pinia'; import { useSchemaPreviewStore } from './schemaPreview.store'; -import * as schemaPreviewApi from '@/api/schemaPreview'; +import * as schemaPreviewApi from './schemaPreview.api'; import type { JSONSchema7 } from 'json-schema'; import { mock } from 'vitest-mock-extended'; import type { PushPayload } from '@n8n/api-types'; -import { useTelemetry } from '../composables/useTelemetry'; +import { useTelemetry } from '@/composables/useTelemetry'; import type { INode } from 'n8n-workflow'; -import { useWorkflowsStore } from './workflows.store'; +import { useWorkflowsStore } from '@/stores/workflows.store'; -vi.mock('@/api/schemaPreview'); +vi.mock('./schemaPreview.api'); vi.mock('@/composables/useTelemetry', () => { const track = vi.fn(); return { diff --git a/packages/frontend/editor-ui/src/stores/schemaPreview.store.ts b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.store.ts similarity index 97% rename from packages/frontend/editor-ui/src/stores/schemaPreview.store.ts rename to packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.store.ts index ca3f9c3bb9d..12de5f2cf01 100644 --- a/packages/frontend/editor-ui/src/stores/schemaPreview.store.ts +++ b/packages/frontend/editor-ui/src/features/ndv/runData/schemaPreview.store.ts @@ -1,4 +1,4 @@ -import * as schemaPreviewApi from '@/api/schemaPreview'; +import * as schemaPreviewApi from './schemaPreview.api'; import { createResultError, createResultOk, type Result } from 'n8n-workflow'; import { defineStore } from 'pinia'; import { reactive } from 'vue';