From 90f662e22926f23ec677d23167ddae2993278eb7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= <ivov.src@gmail.com>
Date: Wed, 7 May 2025 13:11:36 +0200
Subject: [PATCH] chore(core): Remove `role` table (#15172)

---
 .../common/1745934666077-DropRoleTable.ts           | 13 +++++++++++++
 .../cli/src/databases/migrations/mysqldb/index.ts   |  2 ++
 .../src/databases/migrations/postgresdb/index.ts    |  2 ++
 .../cli/src/databases/migrations/sqlite/index.ts    |  2 ++
 4 files changed, 19 insertions(+)
 create mode 100644 packages/cli/src/databases/migrations/common/1745934666077-DropRoleTable.ts

diff --git a/packages/cli/src/databases/migrations/common/1745934666077-DropRoleTable.ts b/packages/cli/src/databases/migrations/common/1745934666077-DropRoleTable.ts
new file mode 100644
index 00000000000..e14066645f2
--- /dev/null
+++ b/packages/cli/src/databases/migrations/common/1745934666077-DropRoleTable.ts
@@ -0,0 +1,13 @@
+import type { IrreversibleMigration, MigrationContext } from '@/databases/types';
+
+/**
+ * Drop the `role` table introduced by `CreateUserManagement1646992772331` and later
+ * abandoned with the move to `@n8n/permissions` in https://github.com/n8n-io/n8n/pull/7650
+ *
+ * Irreversible as there is no use case for restoring a long unused table.
+ */
+export class DropRoleTable1745934666077 implements IrreversibleMigration {
+	async up({ schemaBuilder: { dropTable } }: MigrationContext) {
+		await dropTable('role');
+	}
+}
diff --git a/packages/cli/src/databases/migrations/mysqldb/index.ts b/packages/cli/src/databases/migrations/mysqldb/index.ts
index 31f1de4b13d..db933348fb5 100644
--- a/packages/cli/src/databases/migrations/mysqldb/index.ts
+++ b/packages/cli/src/databases/migrations/mysqldb/index.ts
@@ -86,6 +86,7 @@ import { RenameAnalyticsToInsights1741167584277 } from '../common/1741167584277-
 import { AddScopesColumnToApiKeys1742918400000 } from '../common/1742918400000-AddScopesColumnToApiKeys';
 import { AddWorkflowStatisticsRootCount1745587087521 } from '../common/1745587087521-AddWorkflowStatisticsRootCount';
 import { AddWorkflowArchivedColumn1745934666076 } from '../common/1745934666076-AddWorkflowArchivedColumn';
+import { DropRoleTable1745934666077 } from '../common/1745934666077-DropRoleTable';
 import { UpdateParentFolderIdColumn1740445074052 } from '../mysqldb/1740445074052-UpdateParentFolderIdColumn';
 
 export const mysqlMigrations: Migration[] = [
@@ -176,4 +177,5 @@ export const mysqlMigrations: Migration[] = [
 	AddScopesColumnToApiKeys1742918400000,
 	AddWorkflowStatisticsRootCount1745587087521,
 	AddWorkflowArchivedColumn1745934666076,
+	DropRoleTable1745934666077,
 ];
diff --git a/packages/cli/src/databases/migrations/postgresdb/index.ts b/packages/cli/src/databases/migrations/postgresdb/index.ts
index a40be8a7b37..026da1dfc15 100644
--- a/packages/cli/src/databases/migrations/postgresdb/index.ts
+++ b/packages/cli/src/databases/migrations/postgresdb/index.ts
@@ -86,6 +86,7 @@ import { RenameAnalyticsToInsights1741167584277 } from '../common/1741167584277-
 import { AddScopesColumnToApiKeys1742918400000 } from '../common/1742918400000-AddScopesColumnToApiKeys';
 import { AddWorkflowStatisticsRootCount1745587087521 } from '../common/1745587087521-AddWorkflowStatisticsRootCount';
 import { AddWorkflowArchivedColumn1745934666076 } from '../common/1745934666076-AddWorkflowArchivedColumn';
+import { DropRoleTable1745934666077 } from '../common/1745934666077-DropRoleTable';
 
 export const postgresMigrations: Migration[] = [
 	InitialMigration1587669153312,
@@ -174,4 +175,5 @@ export const postgresMigrations: Migration[] = [
 	AddScopesColumnToApiKeys1742918400000,
 	AddWorkflowStatisticsRootCount1745587087521,
 	AddWorkflowArchivedColumn1745934666076,
+	DropRoleTable1745934666077,
 ];
diff --git a/packages/cli/src/databases/migrations/sqlite/index.ts b/packages/cli/src/databases/migrations/sqlite/index.ts
index d29cb456be3..a931c6fd2be 100644
--- a/packages/cli/src/databases/migrations/sqlite/index.ts
+++ b/packages/cli/src/databases/migrations/sqlite/index.ts
@@ -83,6 +83,7 @@ import { CreateAnalyticsTables1739549398681 } from '../common/1739549398681-Crea
 import { RenameAnalyticsToInsights1741167584277 } from '../common/1741167584277-RenameAnalyticsToInsights';
 import { AddWorkflowStatisticsRootCount1745587087521 } from '../common/1745587087521-AddWorkflowStatisticsRootCount';
 import { AddWorkflowArchivedColumn1745934666076 } from '../common/1745934666076-AddWorkflowArchivedColumn';
+import { DropRoleTable1745934666077 } from '../common/1745934666077-DropRoleTable';
 
 const sqliteMigrations: Migration[] = [
 	InitialMigration1588102412422,
@@ -168,6 +169,7 @@ const sqliteMigrations: Migration[] = [
 	AddScopesColumnToApiKeys1742918400000,
 	AddWorkflowStatisticsRootCount1745587087521,
 	AddWorkflowArchivedColumn1745934666076,
+	DropRoleTable1745934666077,
 ];
 
 export { sqliteMigrations };