github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-05-29 15:57:00 +02:00
Code Issues Actions 27 Packages Projects Releases Wiki Activity Graph

refactor(editor): Extract banners into features/shared (no-changelog) (#20964)

Browse Source
This commit is contained in:
Alex Grozav 2025-10-22 11:02:41 +03:00 committed by GitHub
parent dd6145879f
commit 86d291233f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
16 changed files with 29 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/frontend/editor-ui/src/App.vue
View File

@ -3,7 +3,7 @@ import '@/polyfills';
import AssistantsHub from '@/features/ai/assistant/components/AssistantsHub.vue';
import AskAssistantFloatingButton from '@/features/ai/assistant/components/Chat/AskAssistantFloatingButton.vue';
import BannerStack from '@/components/banners/BannerStack.vue';
import BannerStack from '@/features/shared/banners/components/BannerStack.vue';
import Modals from '@/components/Modals.vue';
import Telemetry from '@/components/Telemetry.vue';
import { useHistoryHelper } from '@/composables/useHistoryHelper';

9
packages/frontend/editor-ui/src/Interface.ts
View File

@ -1,7 +1,5 @@
import type { Component } from 'vue';
import type { NotificationOptions as ElementNotificationOptions } from 'element-plus';
import type {
BannerName,
FrontendSettings,
IUserManagementSettings,
IVersionNotificationSettings,
@ -886,13 +884,6 @@ export type UTMCampaign =
| 'upgrade-builder'
| 'upgrade-custom-roles';
export type N8nBanners = {
[key in BannerName]: {
priority: number;
component: Component;
};
};
export type AddedNode = {
type: string;
openDetail?: boolean;

3
packages/frontend/editor-ui/src/components/Banner.vue
View File

@ -1,4 +1,7 @@
<script setup lang="ts">
/**
* @TODO Move to design system
*/
import { ref } from 'vue';
import { ElTag } from 'element-plus';

9
packages/frontend/editor-ui/src/features/shared/banners/banners.types.ts Normal file
View File

@ -0,0 +1,9 @@
import type { Component } from 'vue';
import type { BannerName } from '@n8n/api-types';
export type N8nBanners = {
[key in BannerName]: {
priority: number;
component: Component;
};
};

16
packages/frontend/editor-ui/src/components/banners/BannerStack.vue → packages/frontend/editor-ui/src/features/shared/banners/components/BannerStack.vue
View File

@ -1,13 +1,13 @@
<script lang="ts">
import NonProductionLicenseBanner from '@/components/banners/NonProductionLicenseBanner.vue';
import TrialOverBanner from '@/components/banners/TrialOverBanner.vue';
import TrialBanner from '@/components/banners/TrialBanner.vue';
import V1Banner from '@/components/banners/V1Banner.vue';
import EmailConfirmationBanner from '@/components/banners/EmailConfirmationBanner.vue';
import DataTableStorageLimitWarningBanner from '@/components/banners/DataTableStorageLimitWarningBanner.vue';
import DataTableStorageLimitErrorBanner from '@/components/banners/DataTableStorageLimitErrorBanner.vue';
import NonProductionLicenseBanner from './banners/NonProductionLicenseBanner.vue';
import TrialOverBanner from './banners/TrialOverBanner.vue';
import TrialBanner from './banners/TrialBanner.vue';
import V1Banner from './banners/V1Banner.vue';
import EmailConfirmationBanner from './banners/EmailConfirmationBanner.vue';
import DataTableStorageLimitWarningBanner from './banners/DataTableStorageLimitWarningBanner.vue';
import DataTableStorageLimitErrorBanner from './banners/DataTableStorageLimitErrorBanner.vue';
import type { Component } from 'vue';
import type { N8nBanners } from '@/Interface';
import type { N8nBanners } from '../banners.types';
// All banners that can be shown in the app should be registered here.
// This component renders the banner with the highest priority from the banner stack, located in the UI store.

2
packages/frontend/editor-ui/src/components/BannersStack.test.ts → packages/frontend/editor-ui/src/features/shared/banners/components/BannersStack.test.ts
View File

@ -6,7 +6,7 @@ import { ROLE } from '@n8n/api-types';
import { STORES } from '@n8n/stores';
import { createTestingPinia } from '@pinia/testing';
import BannerStack from '@/components/banners/BannerStack.vue';
import BannerStack from './BannerStack.vue';
import type { RenderOptions } from '@/__tests__/render';
import { createComponentRenderer } from '@/__tests__/render';
import { waitFor } from '@testing-library/vue';

0
packages/frontend/editor-ui/src/components/banners/BaseBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/BaseBanner.vue
View File

2
packages/frontend/editor-ui/src/components/banners/DataTableStorageLimitErrorBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/DataTableStorageLimitErrorBanner.vue
View File

@ -1,6 +1,6 @@
<script lang="ts" setup>
import { useI18n } from '@n8n/i18n';
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { useDataTableStore } from '@/features/core/dataTable/dataTable.store';
const dataTableStore = useDataTableStore();

2
packages/frontend/editor-ui/src/components/banners/DataTableStorageLimitWarningBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/DataTableStorageLimitWarningBanner.vue
View File

@ -1,6 +1,6 @@
<script lang="ts" setup>
import { useI18n } from '@n8n/i18n';
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { useDataTableStore } from '@/features/core/dataTable/dataTable.store';
const dataTableStore = useDataTableStore();

2
packages/frontend/editor-ui/src/components/banners/EmailConfirmationBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/EmailConfirmationBanner.vue
View File

@ -1,5 +1,5 @@
<script lang="ts" setup>
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { useToast } from '@/composables/useToast';
import { i18n as locale } from '@n8n/i18n';
import { useUsersStore } from '@/features/settings/users/users.store';

2
packages/frontend/editor-ui/src/components/banners/NonProductionLicenseBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/NonProductionLicenseBanner.vue
View File

@ -1,5 +1,5 @@
<script lang="ts" setup>
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { i18n as locale } from '@n8n/i18n';
</script>

2
packages/frontend/editor-ui/src/components/banners/TrialBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/TrialBanner.vue
View File

@ -1,5 +1,5 @@
<script lang="ts" setup>
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { i18n as locale } from '@n8n/i18n';
import { useCloudPlanStore } from '@/stores/cloudPlan.store';
import { computed } from 'vue';

2
packages/frontend/editor-ui/src/components/banners/TrialOverBanner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/TrialOverBanner.vue
View File

@ -1,5 +1,5 @@
<script lang="ts" setup>
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { usePageRedirectionHelper } from '@/composables/usePageRedirectionHelper';
import { i18n as locale } from '@n8n/i18n';

0
packages/frontend/editor-ui/src/components/banners/V1Banner.test.ts → packages/frontend/editor-ui/src/features/shared/banners/components/banners/V1Banner.test.ts
View File

2
packages/frontend/editor-ui/src/components/banners/V1Banner.vue → packages/frontend/editor-ui/src/features/shared/banners/components/banners/V1Banner.vue
View File

@ -1,6 +1,6 @@
<script lang="ts" setup>
import { computed } from 'vue';
import BaseBanner from '@/components/banners/BaseBanner.vue';
import BaseBanner from './BaseBanner.vue';
import { i18n as locale } from '@n8n/i18n';
import { hasPermission } from '@/utils/rbac/permissions';
import { useUIStore } from '@/stores/ui.store';

0
packages/frontend/editor-ui/src/components/banners/__snapshots__/V1Banner.test.ts.snap → packages/frontend/editor-ui/src/features/shared/banners/components/banners/__snapshots__/V1Banner.test.ts.snap
View File