github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-07-28 03:24:59 +02:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity Graph

test(MCP Client Tool Node): Cover error-result handling in executeMcpTool (no-changelog) (#32583)

Browse Source 
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Emilia 2026-06-26 09:00:21 +01:00 committed by GitHub
parent 9fda7b3981
commit 83309b6a60
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
packages/@n8n/nodes-langchain/nodes/mcp/shared/runtime.test.ts
View File

@ -401,6 +401,48 @@ describe('runtime', () => {
await expect(executeMcpTool(ctx, () => baseConfig)).rejects.toThrow('network');
expect(closeSpy).toHaveBeenCalled();
});
// A tool result flagged `isError` must throw rather than be returned as node
// output. Only a thrown error reaches the execution engine's node-failure
// handling, which is what routes the error back to the calling agent.
it('throws with the tool error text when the tool result is flagged isError (v1.3+)', async () => {
jest.spyOn(Client.prototype, 'connect').mockResolvedValue();
jest.spyOn(Client.prototype, 'listTools').mockResolvedValue({ tools: [sampleTool] });
jest.spyOn(Client.prototype, 'callTool').mockResolvedValue({
isError: true,
content: [{ type: 'text', text: 'MCP error -32602: bad arguments' }],
});
const ctx = createExecuteCtx([{ json: { tool: buildMcpToolName('MCP', 'search') } }], {
getNode: jest.fn(() => mock<INode>({ typeVersion: 1.3, name: 'MCP', type: 'mcp' })),
});
await expect(executeMcpTool(ctx, () => baseConfig)).rejects.toThrow(
'MCP error -32602: bad arguments',
);
});
// Throwing on isError only applies to typeVersion >= 1.3; older nodes
// pass the flagged result through as normal output.
it('returns the flagged result without throwing for nodes before v1.3', async () => {
jest.spyOn(Client.prototype, 'connect').mockResolvedValue();
jest.spyOn(Client.prototype, 'listTools').mockResolvedValue({ tools: [sampleTool] });
jest.spyOn(Client.prototype, 'callTool').mockResolvedValue({
isError: true,
content: [{ type: 'text', text: 'some error' }],
});
jest.spyOn(Client.prototype, 'close').mockResolvedValue();
const ctx = createExecuteCtx([{ json: { tool: buildMcpToolName('MCP', 'search') } }], {
getNode: jest.fn(() => mock<INode>({ typeVersion: 1.2, name: 'MCP', type: 'mcp' })),
});
const result = await executeMcpTool(ctx, () => baseConfig);
expect(result[0][0].json).toEqual({
response: [{ type: 'text', text: 'some error' }],
});
});
});
describe('executeMcpTool session cache', () => {