From 7492944a37584d510940f8ee0a2f77fc6ff6a8cd Mon Sep 17 00:00:00 2001 From: Dana <152518854+dana-gill@users.noreply.github.com> Date: Fri, 6 Jun 2025 17:40:08 +0200 Subject: [PATCH] fix(editor): Maintain back button when installing community nodes (#16069) --- .../NodeCreator/Panel/CommunityNodeDetails.test.ts | 4 +++- .../Node/NodeCreator/Panel/CommunityNodeDetails.vue | 11 +++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.test.ts b/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.test.ts index 4afa0a80e24..95b56434b3a 100644 --- a/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.test.ts +++ b/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.test.ts @@ -30,6 +30,7 @@ const getAllNodeCreateElements = vi.fn(() => [ const popViewStack = vi.fn(); const pushViewStack = vi.fn(); +const updateCurrentViewStack = vi.fn(); const showError = vi.fn(); @@ -114,6 +115,7 @@ vi.mock('../composables/useViewStacks', () => ({ }, pushViewStack, popViewStack, + updateCurrentViewStack, getAllNodeCreateElements, })), })); @@ -148,6 +150,7 @@ describe('CommunityNodeDetails', () => { expect(fetchCredentialTypes).toHaveBeenCalledWith(true); expect(getAllNodeCreateElements).toHaveBeenCalled(); expect(popViewStack).toHaveBeenCalled(); + expect(updateCurrentViewStack).toHaveBeenCalled(); expect(pushViewStack).toHaveBeenCalledWith( { communityNodeDetails: { @@ -184,7 +187,6 @@ describe('CommunityNodeDetails', () => { title: 'Node details', }, { - resetStacks: true, transitionDirection: 'none', }, ); diff --git a/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.vue b/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.vue index 75226f03330..2ebf7e15742 100644 --- a/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.vue +++ b/packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.vue @@ -16,7 +16,13 @@ import { prepareCommunityNodeDetailsViewStack, removePreviewToken } from '../uti import { N8nText } from '@n8n/design-system'; -const { activeViewStack, pushViewStack, popViewStack, getAllNodeCreateElements } = useViewStacks(); +const { + activeViewStack, + pushViewStack, + popViewStack, + getAllNodeCreateElements, + updateCurrentViewStack, +} = useViewStacks(); const { communityNodeDetails } = activeViewStack; @@ -37,6 +43,8 @@ const updateViewStack = (key: string) => { popViewStack(); + updateCurrentViewStack({ searchItems: nodeCreatorStore.mergedNodes }); + const viewStack = prepareCommunityNodeDetailsViewStack( installedNode, getNodeIconSource(installedNode.properties), @@ -45,7 +53,6 @@ const updateViewStack = (key: string) => { ); pushViewStack(viewStack, { - resetStacks: true, transitionDirection: 'none', }); } else {