github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-05-12 16:10:30 +02:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

fix(Stripe Node): Prevent duplicate webhook creation on workflow republish

Browse Source 
When a workflow with a Stripe trigger is republished, the webhook was being
deleted and recreated, causing duplicate webhooks in Stripe. This fix checks
the activation mode and skips webhook deletion when the mode is 'update',
preserving the existing webhook.
This commit is contained in:
Lilian Sevoumian 2026-01-05 20:18:37 +01:00
parent 7610a50f49
commit 6e8ac37723
2 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/nodes-base/nodes/Stripe/StripeTrigger.node.ts
View File

@ -922,6 +922,14 @@ export class StripeTrigger implements INodeType {
return true;
},
async delete(this: IHookFunctions): Promise<boolean> {
const activationMode = this.getActivationMode();
// When the workflow is being updated (re-published), keep the existing
// Stripe webhook to avoid creating duplicates
if (activationMode === 'update') {
return true;
}
const webhookData = this.getWorkflowStaticData('node');
if (webhookData.webhookId !== undefined) {

47
packages/nodes-base/nodes/Stripe/__tests__/StripeTrigger.node.test.ts
View File

@ -103,6 +103,53 @@ describe('Stripe Trigger Node', () => {
expect(requestBody).toHaveProperty('api_version', '2025-05-28.basil');
});
describe('webhook delete method', () => {
it('should skip deletion when activation mode is update', async () => {
(mockNodeFunctions.getActivationMode as jest.Mock).mockReturnValue('update');
const staticData = { webhookId: 'we_existing123' };
(mockNodeFunctions.getWorkflowStaticData as jest.Mock).mockReturnValue(staticData);
const result = await node.webhookMethods.default.delete.call(mockNodeFunctions);
expect(result).toBe(true);
expect(mockedStripeApiRequest).not.toHaveBeenCalled();
expect(staticData.webhookId).toBe('we_existing123');
});
it('should delete webhook when activation mode is activate', async () => {
(mockNodeFunctions.getActivationMode as jest.Mock).mockReturnValue('activate');
const staticData: Record<string, unknown> = {
webhookId: 'we_existing123',
webhookEvents: ['*'],
webhookSecret: 'whsec_test',
};
(mockNodeFunctions.getWorkflowStaticData as jest.Mock).mockReturnValue(staticData);
mockedStripeApiRequest.mockResolvedValue({});
const result = await node.webhookMethods.default.delete.call(mockNodeFunctions);
expect(result).toBe(true);
expect(mockedStripeApiRequest).toHaveBeenCalledWith(
'DELETE',
'/webhook_endpoints/we_existing123',
{},
);
expect(staticData.webhookId).toBeUndefined();
expect(staticData.webhookEvents).toBeUndefined();
expect(staticData.webhookSecret).toBeUndefined();
});
it('should return true when no webhook exists to delete', async () => {
(mockNodeFunctions.getActivationMode as jest.Mock).mockReturnValue('activate');
(mockNodeFunctions.getWorkflowStaticData as jest.Mock).mockReturnValue({});
const result = await node.webhookMethods.default.delete.call(mockNodeFunctions);
expect(result).toBe(true);
expect(mockedStripeApiRequest).not.toHaveBeenCalled();
});
});
describe('webhook signature verification', () => {
let mockWebhookFunctions: IWebhookFunctions;
const testBody = { type: 'charge.succeeded', id: 'ch_123' };