From 6cd984fb830ce2043ebfa18550ca6ecb9c57c25b Mon Sep 17 00:00:00 2001 From: "n8n-cat-bot[bot]" <283985454+n8n-cat-bot[bot]@users.noreply.github.com> Date: Wed, 2 Sep 2026 16:46:04 +0000 Subject: [PATCH] chore: Disable CodSpeed job on pull requests, keep it on post-merge only (#37666) Co-authored-by: n8n-cat-bot[bot] Co-authored-by: Claude Opus 5 --- .github/workflows/ci-master.yml | 2 ++ .github/workflows/ci-pull-requests.yml | 15 --------------- packages/testing/performance/README.md | 4 ++-- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/.github/workflows/ci-master.yml b/.github/workflows/ci-master.yml index 50d9424f539..8511be425af 100644 --- a/.github/workflows/ci-master.yml +++ b/.github/workflows/ci-master.yml @@ -46,6 +46,8 @@ jobs: with: ref: ${{ github.sha }} + # CodSpeed benchmarks run post-merge only. On PRs they failed for reasons + # unrelated to the change, so the red check gave authors no usable signal. performance: name: Performance uses: ./.github/workflows/test-bench-reusable.yml diff --git a/.github/workflows/ci-pull-requests.yml b/.github/workflows/ci-pull-requests.yml index 3b4c143b94c..ad23754595d 100644 --- a/.github/workflows/ci-pull-requests.yml +++ b/.github/workflows/ci-pull-requests.yml @@ -27,7 +27,6 @@ jobs: workflows: ${{ fromJSON(steps.ci-filter.outputs.results).workflows == true }} workflow_scripts: ${{ fromJSON(steps.ci-filter.outputs.results)['workflow-scripts'] == true }} db: ${{ fromJSON(steps.ci-filter.outputs.results).db == true }} - performance: ${{ fromJSON(steps.ci-filter.outputs.results).performance == true }} e2e_performance: ${{ fromJSON(steps.ci-filter.outputs.results)['e2e-performance'] == true }} instance_ai_workflow_eval: ${{ fromJSON(steps.ci-filter.outputs.results)['instance-ai-workflow-eval'] == true }} commit_sha: ${{ steps.commit-sha.outputs.sha }} @@ -120,11 +119,6 @@ jobs: scripts/mutation-health/** cubic.yaml .agents/review-rules/** - performance: - packages/testing/performance/** - packages/workflow/src/** - packages/@n8n/expression-runtime/src/** - .github/workflows/test-bench-reusable.yml e2e-performance: packages/testing/playwright/tests/performance/** packages/testing/playwright/utils/performance-helper.ts @@ -323,14 +317,6 @@ jobs: ref: ${{ needs.install-and-build.outputs.commit_sha }} matrix: ${{ needs.install-and-build.outputs.db_test_matrix }} - performance: - name: Performance - needs: install-and-build - if: needs.install-and-build.outputs.performance == 'true' && github.event_name != 'merge_group' - uses: ./.github/workflows/test-bench-reusable.yml - with: - ref: ${{ needs.install-and-build.outputs.commit_sha }} - e2e-performance: name: E2E Performance needs: [install-and-build, prepare-docker] @@ -396,7 +382,6 @@ jobs: e2e, dev-server-smoke, db-tests, - performance, security-checks, workflow-scripts, ] diff --git a/packages/testing/performance/README.md b/packages/testing/performance/README.md index 66624de3329..f6903996f41 100644 --- a/packages/testing/performance/README.md +++ b/packages/testing/performance/README.md @@ -27,9 +27,9 @@ pnpm --filter=@n8n/performance bench:compare # Compare against baseline (>10% ## CI Regression Detection -Benchmarks run automatically on PRs that touch `packages/testing/performance/**` or `packages/workflow/src/**`. [CodSpeed](https://codspeed.io) counts CPU instructions instead of wall-clock time, producing deterministic results regardless of runner load. It comments on PRs with results and regression warnings. +Benchmarks run automatically on every push to `master`, not on pull requests. [CodSpeed](https://codspeed.io) counts CPU instructions instead of wall-clock time, producing deterministic results regardless of runner load. It reports results and regression warnings against the master trend. -You can also trigger benchmarks manually for any branch via **Actions > Test: Benchmarks > Run workflow**. +To benchmark a change before you merge it, trigger the run manually for your branch via **Actions > Test: Benchmarks > Run workflow**. ### Local vs CI