From 6c8197e379eebe8096773fbdeb730ec1a9b1323b Mon Sep 17 00:00:00 2001 From: Kai Date: Tue, 4 Aug 2026 14:54:26 +0200 Subject: [PATCH] feat(editor): Add Changes diff tab to workflow review detail pane (#35431) --- .../frontend/@n8n/i18n/src/locales/en.json | 12 +- .../app/components/layouts/PageViewLayout.vue | 13 +- .../WorkflowReviewChangesSection.test.ts | 207 ++++++++++++ .../WorkflowReviewChangesSection.vue | 162 ++++++++++ .../WorkflowReviewDetailTabs.test.ts | 299 ++++++++++++++++++ .../components/WorkflowReviewDetailTabs.vue | 183 +++++++++++ .../WorkflowReviewRequestsSidebar.vue | 11 +- .../features/workflow-reviews/constants.ts | 4 +- .../views/WorkflowReviewRequestsView.test.ts | 144 ++++++++- .../views/WorkflowReviewRequestsView.vue | 90 ++---- 10 files changed, 1043 insertions(+), 82 deletions(-) create mode 100644 packages/frontend/editor-ui/src/features/workflow-reviews/components/WorkflowReviewChangesSection.test.ts create mode 100644 packages/frontend/editor-ui/src/features/workflow-reviews/components/WorkflowReviewChangesSection.vue create mode 100644 packages/frontend/editor-ui/src/features/workflow-reviews/components/WorkflowReviewDetailTabs.test.ts create mode 100644 packages/frontend/editor-ui/src/features/workflow-reviews/components/WorkflowReviewDetailTabs.vue diff --git a/packages/frontend/@n8n/i18n/src/locales/en.json b/packages/frontend/@n8n/i18n/src/locales/en.json index 0ea6f49c956..26f430a53e6 100644 --- a/packages/frontend/@n8n/i18n/src/locales/en.json +++ b/packages/frontend/@n8n/i18n/src/locales/en.json @@ -5400,7 +5400,17 @@ "workflowReviews.status.changesRequested": "Changes requested", "workflowReviews.status.approved": "Approved", "workflowReviews.status.closed": "Closed", - "workflowReviews.detail.placeholder": "Full review details are coming soon.", + "workflowReviews.detail.tabs.activity": "Activity", + "workflowReviews.detail.tabs.changes": "Changes", + "workflowReviews.detail.activity.noDescription": "No description provided.", + "workflowReviews.changes.closed.body": "Changes aren't shown for closed reviews.", + "workflowReviews.changes.empty": "This review doesn't contain any workflows.", + "workflowReviews.changes.unavailable": "Couldn't load the changes for this review. Refresh to try again.", + "workflowReviews.changes.versionUnavailable.body": "The submitted workflow version is no longer available.", + "workflowReviews.changes.noChanges": "No changes compared to the published version.", + "workflowReviews.changes.sourceLabel": "Published: {version}", + "workflowReviews.changes.targetLabel": "In review: {version}", + "workflowReviews.changes.firstPublish.sourceEmpty": "This workflow hasn't been published before.", "workflowReviews.detail.notFound.title": "Review not found", "workflowReviews.detail.notFound.body": "This review doesn't exist or you don't have access to it.", "workflowReviews.detail.decision.approve": "Approve", diff --git a/packages/frontend/editor-ui/src/app/components/layouts/PageViewLayout.vue b/packages/frontend/editor-ui/src/app/components/layouts/PageViewLayout.vue index 8cf398ad7f4..a2a725f9f27 100644 --- a/packages/frontend/editor-ui/src/app/components/layouts/PageViewLayout.vue +++ b/packages/frontend/editor-ui/src/app/components/layouts/PageViewLayout.vue @@ -1,5 +1,11 @@ + +