From 56b16b8c0fb4cff4d51134ef532dede4ccac2707 Mon Sep 17 00:00:00 2001 From: Guillaume Jacquart Date: Wed, 11 Jun 2025 13:36:29 +0200 Subject: [PATCH] fix(core): Remove duplicated logs for insights (#16228) --- .../cli/src/modules/insights/insights-collection.service.ts | 1 + .../cli/src/modules/insights/insights-pruning.service.ts | 4 ++-- packages/cli/src/modules/insights/insights.service.ts | 5 ----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/cli/src/modules/insights/insights-collection.service.ts b/packages/cli/src/modules/insights/insights-collection.service.ts index bdeceadc027..291b8aeeff8 100644 --- a/packages/cli/src/modules/insights/insights-collection.service.ts +++ b/packages/cli/src/modules/insights/insights-collection.service.ts @@ -76,6 +76,7 @@ export class InsightsCollectionService { startFlushingTimer() { this.isAsynchronouslySavingInsights = true; this.scheduleFlushing(); + this.logger.debug('Started flushing timer'); } scheduleFlushing() { diff --git a/packages/cli/src/modules/insights/insights-pruning.service.ts b/packages/cli/src/modules/insights/insights-pruning.service.ts index c4235929470..6878aa3e082 100644 --- a/packages/cli/src/modules/insights/insights-pruning.service.ts +++ b/packages/cli/src/modules/insights/insights-pruning.service.ts @@ -42,7 +42,7 @@ export class InsightsPruningService { this.clearPruningTimer(); this.isStopped = false; this.scheduleNextPrune(); - this.logger.debug(`Insights pruning every ${this.config.pruneCheckIntervalHours} hours`); + this.logger.debug('Started pruning timer'); } private clearPruningTimer() { @@ -55,7 +55,7 @@ export class InsightsPruningService { stopPruningTimer() { this.isStopped = true; this.clearPruningTimer(); - this.logger.debug('Stopped Insights pruning'); + this.logger.debug('Stopped pruning timer'); } private scheduleNextPrune( diff --git a/packages/cli/src/modules/insights/insights.service.ts b/packages/cli/src/modules/insights/insights.service.ts index 65eb3e38d2e..291444c4c85 100644 --- a/packages/cli/src/modules/insights/insights.service.ts +++ b/packages/cli/src/modules/insights/insights.service.ts @@ -42,7 +42,6 @@ export class InsightsService { startTimers() { this.collectionService.startFlushingTimer(); - this.logger.debug('Started flushing timer'); // Start compaction and pruning timers for main leader instance only if (this.instanceSettings.isLeader) { @@ -53,19 +52,15 @@ export class InsightsService { @OnLeaderTakeover() startCompactionAndPruningTimers() { this.compactionService.startCompactionTimer(); - this.logger.debug('Started compaction timer'); if (this.pruningService.isPruningEnabled) { this.pruningService.startPruningTimer(); - this.logger.debug('Started pruning timer'); } } @OnLeaderStepdown() stopCompactionAndPruningTimers() { this.compactionService.stopCompactionTimer(); - this.logger.debug('Stopped compaction timer'); this.pruningService.stopPruningTimer(); - this.logger.debug('Stopped pruning timer'); } @OnShutdown()