github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-05-29 15:57:00 +02:00
Code Issues Actions 27 Packages Projects Releases Wiki Activity Graph

refactor(core): Split n8nContainer into two Playwright fixtures (no-changelog) (#30912)

Browse Source 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Declan Carroll 2026-05-22 10:40:21 +01:00 committed by GitHub
parent a1a8e3d693
commit 51415e1446
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 45 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
packages/testing/playwright/fixtures/base.ts
View File

@ -47,6 +47,7 @@ type WorkerFixtures = {
backendUrl: string;
frontendUrl: string;
dbSetup: undefined;
n8nStackConfig: N8NConfig;
n8nContainer: N8NStack;
capability?: CapabilityOption;
};
@ -54,6 +55,25 @@ type WorkerFixtures = {
type CapabilityOption = Capability | N8NConfig;
type ProjectUse = { containerConfig?: N8NConfig };
function parseGlobalTestEnv(): Record<string, string> {
const raw = process.env.N8N_TEST_ENV;
if (!raw) return {};
try {
return JSON.parse(raw) as Record<string, string>;
} catch {
console.warn('[base.ts] Failed to parse N8N_TEST_ENV');
return {};
}
}
function logKeepalive(container: N8NStack): void {
console.log('\n=== KEEPALIVE: Containers left running for debugging ===');
console.log(` URL: ${container.baseUrl}`);
console.log(` Project: ${container.projectName}`);
console.log(' Cleanup: pnpm --filter n8n-containers stack:clean:all');
console.log('=========================================================\n');
}
export const test = base.extend<
TestFixtures & CurrentsFixtures & ObservabilityTestFixtures & QuarantineTestFixtures,
WorkerFixtures & CurrentsWorkerFixtures & QuarantineWorkerFixtures
@ -68,15 +88,11 @@ export const test = base.extend<
// Option for test.use({ capability: 'proxy' }) - transformed into N8NStack by n8nContainer
capability: [undefined, { scope: 'worker', option: true }],
// Creates container from: project.containerConfig (base) + capability (override)
// When N8N_BASE_URL is set, skips container creation for local testing
n8nContainer: [
// Resolves the effective N8NConfig from project.containerConfig (base) +
// capability (override) + N8N_TEST_ENV (global). Topology-neutral: it
// always produces a config, even when a container will not be provisioned.
n8nStackConfig: [
async ({ capability }, use, workerInfo) => {
if (getBackendUrl()) {
await use(null!);
return;
}
const { containerConfig: base = {} } = workerInfo.project.use as ProjectUse;
const override: N8NConfig = !capability
? {}
@ -84,16 +100,7 @@ export const test = base.extend<
? CAPABILITIES[capability]
: capability;
const globalEnv: Record<string, string> = (() => {
const raw = process.env.N8N_TEST_ENV;
if (!raw) return {};
try {
return JSON.parse(raw) as Record<string, string>;
} catch {
console.warn('[base.ts] Failed to parse N8N_TEST_ENV');
return {};
}
})();
const globalEnv = parseGlobalTestEnv();
const config: N8NConfig = {
...base,
@ -108,15 +115,25 @@ export const test = base.extend<
},
};
const container = await createN8NStack(config);
await use(config);
},
{ scope: 'worker', box: true },
],
// Creates container from n8nStackConfig.
// When N8N_BASE_URL is set, skips container creation for local testing.
n8nContainer: [
async ({ n8nStackConfig }, use) => {
if (getBackendUrl()) {
await use(null!);
return;
}
const container = await createN8NStack(n8nStackConfig);
await use(container);
if (process.env.N8N_CONTAINERS_KEEPALIVE === 'true') {
console.log('\n=== KEEPALIVE: Containers left running for debugging ===');
console.log(` URL: ${container.baseUrl}`);
console.log(` Project: ${container.projectName}`);
console.log(' Cleanup: pnpm --filter n8n-containers stack:clean:all');
console.log('=========================================================\n');
logKeepalive(container);
return;
}
@ -313,11 +330,12 @@ export { expect };
/*
Fixture Dependency Graph:
Worker: capability + project.containerConfig → n8nContainer → [backendUrl, frontendUrl, dbSetup]
Worker: capability + project.containerConfig → n8nStackConfig → n8nContainer → [backendUrl, frontendUrl, dbSetup]
Test: frontendUrl + dbSetup → baseURL → n8n (uses backendUrl for API calls)
backendUrl → api
n8nContainer → services
services: Type-safe helpers (mailpit, gitea, proxy, observability, etc.)
n8nContainer: Container lifecycle (stop, containers, mainUrls, etc.)
n8nStackConfig: Resolved N8NConfig (topology-neutral, always produced)
n8nContainer: Container lifecycle (stop, containers, mainUrls, etc.)
services: Type-safe helpers (mailpit, gitea, proxy, observability, etc.)
*/